Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade lodash to ^4.17.15 to eliminate vulnerability #1152

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

TonyJDavies
Copy link
Contributor

This would resolve #1151 to eliminate the npm vulnerability Prototype Pollution identified by https://www.npmjs.com/advisories/1065.

@TonyJDavies TonyJDavies reopened this Jul 26, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.419% when pulling 0befd73 on TonyJDavies:master into e94e2e7 on istanbuljs:master.

@coreyfarrell
Copy link
Member

Note this will not have any effect on your own installations and will not directly result in a new release. This will only fix npm audit messages that would occur when developing/testing nyc itself.

Our production dependency on lodash is installed via semver-range from babel, so nyc@14.1.1 will install the latest non-vulnerable version of lodash assuming you do not have a package-lock.json or yarn.lock blocking it. If you do have a package-lock.json then you need to run npm audit fix from your own project. I do not know the equivalent command to update yarn.lock.

@coreyfarrell coreyfarrell merged commit c358ce1 into istanbuljs:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm advisory #1065 : Prototype Pollution
3 participants