merge #123 with master (upgrade foreground-child, spawn-wrap). #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foreground-child is now using cross-spawn-async in order to be able to properly spawn shebangs and .cmd/.exe files. This avoids the extra cmd.exe that win-spawn throws into the mix, since that causes problems when there is no PATH environ and a binary is being called explicitly via a full path name. Cross-spawn-async is a lot more code than win-spawn, but the approach it takes is more surgical and well-tested. Because of this, it's no longer necessary to unshift the node/io.js binary onto the argument list when spawning a shebanged javascript file. So, doing 'nyc mocha ...' on Windows will now work, and it's no longer necessary to do 'nyc ./node_modules/mocha/bin/mocha.js ...' or any other extra manual path munging.
This was resulting in a opts.require=['undefined'] on Windows.
bcoe
added a commit
that referenced
this pull request
Jan 3, 2016
merge #123 with master (upgrade foreground-child, spawn-wrap).
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge of #123 with master.