(chore) Switch to AppVeyor for Windows testing

[XhmikosR]

@coreyfarrell the only changes you should make in AppVeyor settings are these:

• Skip branches without appveyor.yml
• Save build cache in Pull Requests

Notes:

• we could always install the latest version of Node.js; if you want this let me know
• I haven't added Node.js 13, should I add it?
• I test one x86 build and everything else x64. I don't think it matters, so maybe I should just use x64 for all versions?
• I have added caching (caching the global npm folder) which will be invalidated if any of these files changes: appveyor.yml, package.json, package-lock.json

[coreyfarrell]

Appears I didn't have appveyor fully enabled, this should now be fixed so next time you do a push github should run it.

[XhmikosR]

Alright, I pushed my changes, if it passes I will squash the patches.

So, assuming you made the two changes in settings I mentioned, and you are OK with how this works, you can merge after that.

Forgot to mention I have specified shallow_clone: true which is basically cloning with depth: 1

[coreyfarrell]

Alright, I pushed my changes, if it passes I will squash the patches.

No need, I use Squash and merge on the github interface even if you already squashed. We use commit logs for changelog generation and this gives us the best results (the PR is added to the first line of the commit).

So, assuming you made the two changes in settings I mentioned, and you are OK with how this works, you can merge after that.

Settings are changed per your suggestion.

Forgot to mention I have specified shallow_clone: true which is basically cloning with depth: 1

This is fine.

[XhmikosR]

Some further notes:

No need, I use Squash and merge on the github interface even if you already squashed. We use commit logs for changelog generation and this gives us the best results (the PR is added to the first line of the commit).

I'm still old school :P

1. Always installing the latest Node.js version results in some slowness, ~1min 30s
2. The free AppVeyor plan is limited in concurrency unfortunately

I will push the last changes and if everything is green you can merge.

[XhmikosR]

OK so it seems the Current alias does not work with always using the latest version, or at least I couldn't make it work. I just used 13 for now.

[XhmikosR]

Should I add fast_finish: true?

[coreyfarrell]

Should I add fast_finish: true?

Yes please

[XhmikosR]

One last thing, what is the AppVeyor project URL? it seems https://ci.appveyor.com/project/istanbuljs/nyc isn't right

[XhmikosR]

NVM my mind was stuck for a while :P It's https://ci.appveyor.com/project/coreyfarrell/nyc

[coreyfarrell]

That's weird, I don't understand why it's listed under by username instead of istanbuljs? Did I do something wrong?

[XhmikosR]

I remember I had that issue too in the past. Not sure how to solve it. But I updated the badge/link to point to your project for now.

[coreyfarrell]

Sorry please switch the badge back, I just found the setting so the appveyor URL is now https://ci.appveyor.com/project/istanbuljs/nyc

[XhmikosR]

Alright, this is ready. As much as I'd like to always test against the latest Node.js versions, this is significantly slower. On the other hand this will allow you to test say v14 even before AppVeyor adds it to their images.