Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): node_modules is no longer excluded #352

Merged
merged 1 commit into from
Aug 14, 2016

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Aug 14, 2016

via v8.0.0

Please let me know if I understood this correctly :)

And if you don’t mind me asking here, for a setup like this one:
https://github.com/hoodiehq/spawn-pouchdb-server/blob/master/package.json#L6

Should I know exclude node_modules?

@bcoe
Copy link
Member

bcoe commented Aug 14, 2016

@gr2m you shouldn't need to add exclude rules, node_modules is still omitted in the default group of globs; it's just folks writing custom exclude logic that will need to update.

@bcoe bcoe merged commit edda16f into istanbuljs:master Aug 14, 2016
@gr2m
Copy link
Contributor Author

gr2m commented Aug 14, 2016

Gotcha, thanks Ben!

@gr2m gr2m deleted the patch-1 branch August 14, 2016 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants