fix: add config values to hash salt #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
coreyfarrell
requested changes
Feb 10, 2019
coreyfarrell
approved these changes
Feb 25, 2019
JaKXz
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
@bcoe @coreyfarrell it would be cool if all the issues @taye mentioned could be closed in the merge commit but I'll leave that judgement call to you
|
I think #522 is the only one this should close. The other tickets are either unrelated or of undetermined cause. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the instrumenter-related config options to the salt of the cache hash. This fixes a bug where code that has been cached without instrumentation or source maps is incorrectly reused after the options are later enabled, leading to missing instrumentation. This problem is more likely to come up in projects using
babel-plugin-istanbulwhich recommends setting thesourceMapandinstrumentoptions tofalse.Closes #552 and probably also #822 #822 #974 #980
Thank you to everyone maintaining and contributing to this project ❤️