-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support source map with multiple sources #102
Conversation
Pull Request Test Coverage Report for Build 444
💛 - Coveralls |
I have seen #91 after implementing this. |
@bcoe @lukeapage wdyt? |
@bcoe any chance this could get a review ? |
@MoLow thank you for taking a crack at this, I'll make an effort to give you a more thorough review soon. |
}, | ||
}, | ||
"b": Object {}, | ||
"branchMap": Object {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems weird to me, I wouldn't have expected us to need to update the snapshot for the non-multi-source use-case, and it looks like this updates the snapshot with empty information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcoe this was indeed a bug, I fixed it
Hey @MoLow I've been working on dual mode modules for Issues with yargs-parserI tried running However, when I open an HTML report there are some issues: My guess is we're missing resolving a path somewhere? Issues with c8 test suiteI also ran the test suite against I bet there's a chance these issues are related, and we're just missing a resolve somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some feedback @MoLow 👋 it seems like this work is a good chunk of the way there, just a couple of path related bugs we need to hunt down.
@MoLow update, I got everything debugged; your work was 99% of the way there 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work @MoLow 🎉
Thank you for seeing this feature over the finish line. And thank you @lukeapage for kicking of this work.
Adds support for 1:many source-maps. These source maps are used by tools like rollup or WebPack to bundle multiple JavaScript source files into one. Refs: istanbuljs/v8-to-istanbul#102
Adds support for 1:many source-maps. These source maps are used by tools like rollup or WebPack to bundle multiple JavaScript source files into one. Refs: istanbuljs/v8-to-istanbul#102
Adds support for 1:many source-maps. These source maps are used by tools like rollup or WebPack to bundle multiple JavaScript source files into one. Refs: istanbuljs/v8-to-istanbul#102
Adds support for 1:many source-maps. These source maps are used by tools like rollup or WebPack to bundle multiple JavaScript source files into one. Refs: istanbuljs/v8-to-istanbul#102
No description provided.