Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following global traffic policy example results in unresolved dns records [BUG] #161

Closed
yaron-idan opened this issue Jan 3, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@yaron-idan
Copy link
Contributor

Describe the bug
Not sure if this is a bug actually. I'm trying to follow the example described here but after creating the GlobalTrafficPolicy pods can't resolve to either west.greeting.global or east.greeting.global.
This makes sense because I haven't created anything to instruct these records to be created, but I'm not sure what actions are required to achieve that.

Steps To Reproduce
Create 2 EKS clusters in us-east-1 and us-east-2 regions
Install istio-1.7.6 multicluster on 2 clusters according to this guide
Install admiral on both clusters following this guide

Expected behavior
The failover global traffic policy should be able to route traffic to east.greeting.global locally within us-east-1 cluster, and automatically failover to us-east-2 cluster once health is degraded.

@yaron-idan yaron-idan added the bug Something isn't working label Jan 3, 2021
@yaron-idan yaron-idan changed the title [BUG] Following global traffic policy example results in unresolved dns records [BUG] Jan 12, 2021
@aattuluri aattuluri self-assigned this Jan 12, 2021
@aattuluri
Copy link
Contributor

@yaron-idan This is a feature gap and being worked on #162. Should be available later this week.

@yaron-idan
Copy link
Contributor Author

Thanks @aattuluri , those are great news!

Mengying-Li pushed a commit that referenced this issue Apr 28, 2021
Fixes #163
Fixes #161

Signed-off-by: Mengying <mengyinglimandy@gmail.com>
Mengying-Li added a commit that referenced this issue May 24, 2021
* Add support for gtp with multiple traffic policies (#162)

Fixes #163
Fixes #161

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* Fix mesh port match against to look at k8s svc target port (#165)

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* Add basic health check API  (#171)

* some basic folder

* get the basic curl /health/ready working

* Refactoring api server files

* reverting a very tiny comment that I shouldn't have pushed

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* trying to fix the circle CI error

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* addressed the comment

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

Co-authored-by: vjoshi3 <vrushali_joshi@intuit.com>
Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* Admiral apis (#175)

* added the get all cluste api

Signed-off-by: Mengying <mengyinglimandy@gmail.com>
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* fixed the unit test

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* updated the comment a little bit

Signed-off-by: Mengying <mengyinglimandy@gmail.com>
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* Adding api to get service entries based on given cluster or given identity

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* Refactoring api code

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* Fixing failing tests for service.go

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* Fixing review comments and ci failures

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* Fixing review comments

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* added some unit tests

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* added the cluster id inside deployment controller (#176)

* added the cluster id inside deployment controller

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* fixed the helm setup failure

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* added cluster id in other remote controllers

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* added unit test for api function GetServiceEntriesByCluster

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* fixed a small typing in test

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* fixed some indentation

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* added test for get se by identity

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* added cluster id to be print in log

Co-authored-by: Mengying <mengyinglimandy@gmail.com>
Co-authored-by: vjoshi3 <vrushali_joshi@intuit.com>
Co-authored-by: Mengying-Li <43981707+Mengying-Li@users.noreply.github.com>

* added more context to the API call

Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Co-authored-by: vjoshi3 <vrushali_joshi@intuit.com>
Co-authored-by: vrushalijoshi <vrushalijoshi.cummins@gmail.com>
psikka1 pushed a commit to psikka1/admiral that referenced this issue Jun 15, 2022
* Add support for gtp with multiple traffic policies (istio-ecosystem#162)

Fixes istio-ecosystem#163
Fixes istio-ecosystem#161

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* Fix mesh port match against to look at k8s svc target port (istio-ecosystem#165)

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* Add basic health check API  (istio-ecosystem#171)

* some basic folder

* get the basic curl /health/ready working

* Refactoring api server files

* reverting a very tiny comment that I shouldn't have pushed

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* trying to fix the circle CI error

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* addressed the comment

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

Co-authored-by: vjoshi3 <vrushali_joshi@intuit.com>
Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* Admiral apis (istio-ecosystem#175)

* added the get all cluste api

Signed-off-by: Mengying <mengyinglimandy@gmail.com>
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* fixed the unit test

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* updated the comment a little bit

Signed-off-by: Mengying <mengyinglimandy@gmail.com>
Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* Adding api to get service entries based on given cluster or given identity

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* Refactoring api code

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* Fixing failing tests for service.go

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* Fixing review comments and ci failures

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* Fixing review comments

Signed-off-by: vjoshi3 <vrushali_joshi@intuit.com>

* added some unit tests

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* added the cluster id inside deployment controller (istio-ecosystem#176)

* added the cluster id inside deployment controller

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* fixed the helm setup failure

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* added cluster id in other remote controllers

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* added unit test for api function GetServiceEntriesByCluster

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* fixed a small typing in test

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* fixed some indentation

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* added test for get se by identity

Signed-off-by: Mengying <mengyinglimandy@gmail.com>

* added cluster id to be print in log

Co-authored-by: Mengying <mengyinglimandy@gmail.com>
Co-authored-by: vjoshi3 <vrushali_joshi@intuit.com>
Co-authored-by: Mengying-Li <43981707+Mengying-Li@users.noreply.github.com>

* added more context to the API call

Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Co-authored-by: vjoshi3 <vrushali_joshi@intuit.com>
Co-authored-by: vrushalijoshi <vrushalijoshi.cummins@gmail.com>
Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants