api_transformer: use go env to detect mod cache dir
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgn
force-pushed
the
support-gomodcache-env-var
branch
from
9577824 to
69e180c
Compare
This is more realiable than relying on the environment variables, because the GOMODCACHE directory can be constructed in numerous ways, eg it can be set explicitly or derived from GOPATH like we did before. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
dgn
force-pushed
the
support-gomodcache-env-var
branch
from
69e180c to
c45d5ac
Compare
jwendell
approved these changes
Aug 13, 2024
dgn
added a commit
to dgn/sail-operator
that referenced
this pull request
Aug 13, 2024
…m#269) This is more realiable than relying on the environment variables, because the GOMODCACHE directory can be constructed in numerous ways, eg it can be set explicitly or derived from GOPATH like we did before. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Aug 13, 2024
* upstream/main: Ensure `make gen-check` works when go mod cache is empty (openshift-service-mesh#270) Introduce RemoteIstio (openshift-service-mesh#202) api_transformer: use `go env` to detect mod cache dir (openshift-service-mesh#269) Add field values.experimental to API (openshift-service-mesh#264) Fix errors in tables for api reference documentation (openshift-service-mesh#263) Generate CNIGlobalConfig from GlobalConfig automatically (openshift-service-mesh#260) Fix errors in api reference doc (openshift-service-mesh#262) Rename `addTags` to `addComments` in API transformer (openshift-service-mesh#259) Add relatedImages to ClusterServiceVersion (openshift-service-mesh#243) Generate API from versions defined in go.mod (openshift-service-mesh#258) Fix issues identified during API review (openshift-service-mesh#254) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
istio-testing
pushed a commit
that referenced
this pull request
Aug 13, 2024
This is more realiable than relying on the environment variables, because the GOMODCACHE directory can be constructed in numerous ways, eg it can be set explicitly or derived from GOPATH like we did before. Signed-off-by: Daniel Grimm <dgrimm@redhat.com>
openshift-service-mesh-bot
referenced
this pull request
in openshift-service-mesh-bot/sail-operator
Aug 13, 2024
* upstream/main: Add `RemoteIstio` to API concepts in docs (openshift-service-mesh#272) Ensure `make gen-check` works when go mod cache is empty (openshift-service-mesh#270) Introduce RemoteIstio (openshift-service-mesh#202) api_transformer: use `go env` to detect mod cache dir (openshift-service-mesh#269) Add field values.experimental to API (openshift-service-mesh#264) Fix errors in tables for api reference documentation (openshift-service-mesh#263) Generate CNIGlobalConfig from GlobalConfig automatically (openshift-service-mesh#260) Fix errors in api reference doc (openshift-service-mesh#262) Rename `addTags` to `addComments` in API transformer (openshift-service-mesh#259) Add relatedImages to ClusterServiceVersion (openshift-service-mesh#243) Generate API from versions defined in go.mod (openshift-service-mesh#258) Fix issues identified during API review (openshift-service-mesh#254) # Conflicts: # bundle/manifests/sailoperator.clusterserviceversion.yaml
FilipB
pushed a commit
to FilipB/sail-operator
that referenced
this pull request
Mar 6, 2025
…t/none-main-merge_upstream_main-38a843ce Automator: merge upstream changes to openshift-service-mesh/sail-operator@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more realiable than relying on the environment variables, because the GOMODCACHE directory can be constructed in numerous ways, eg it can be set explicitly or derived from GOPATH like we did before.