Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create namespace if it doesn't exist in README example #36

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Create namespace if it doesn't exist in README example #36

merged 1 commit into from
Apr 11, 2024

Conversation

nrfox
Copy link
Contributor

@nrfox nrfox commented Apr 11, 2024

Updates the README example to create the namespace if it doesn't exist. Otherwise when you just run the example without creating the namespace first the reconciliation will fail.

@nrfox nrfox requested a review from a team as a code owner April 11, 2024 13:36
@istio-testing
Copy link
Collaborator

Hi @nrfox. Thanks for your PR.

I'm waiting for a istio-ecosystem or istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nrfox
Create namespace if it doesn't exist in README example
51bdd57 
Signed-off-by: Nick Fox <nfox@redhat.com>
@nrfox nrfox force-pushed the update-readme-example branch from 5bca567 to 51bdd57 Compare April 11, 2024 13:52
@jwendell
Copy link
Collaborator

Note that the README in the bundle directory is more complete and targets end users.

/ok-to-test

@istio-testing istio-testing merged commit 8a38a43 into istio-ecosystem:main Apr 11, 2024
8 checks passed
@nrfox nrfox deleted the update-readme-example branch April 11, 2024 14:21
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Apr 12, 2024
Automator: merge upstream changes to openshift-service-mesh/sail-oper…
4b24038 
…ator@main

* upstream/main:
  Centralize handling of conflicts and other common errors (openshift-service-mesh#25)
  Create namespace if it doesn't exist in README example (openshift-service-mesh#36)
  Update bot username to openshift-service-mesh-bot (openshift-service-mesh#35)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#34)
  Add `operator-name` target (openshift-service-mesh#33)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#32)
  Add Debug information when e2e Test run Fails (openshift-service-mesh#31)
  Wrap errors (openshift-service-mesh#28)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#27)
  Use the `quote` function to properly escape CSV annotations (openshift-service-mesh#26)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#24)
  Remove the patch that deleted fixed UIDs from istiod charts (openshift-service-mesh#23)
  Review of field deletions in download-charts.sh (openshift-service-mesh#22)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#21)
  Split E2E test (openshift-service-mesh#20)
  Remove v1.20.3, it relies on istio_cni values that we don't support anymore (openshift-service-mesh#17)
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Apr 16, 2024
Automator: merge upstream changes to openshift-service-mesh/sail-oper…
6f2dc33 
…ator@main

* upstream/main: (23 commits)
  Add defaulting for Istio and IstioCNI resources (openshift-service-mesh#43)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#42)
  Fix debug info in e2e tests (openshift-service-mesh#41)
  Update PROJECT file (openshift-service-mesh#40)
  Use exponential backoff for conflicts and gc admission plugin error (openshift-service-mesh#38)
  Handle conflicts on cleanup (openshift-service-mesh#39)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#37)
  Centralize handling of conflicts and other common errors (openshift-service-mesh#25)
  Create namespace if it doesn't exist in README example (openshift-service-mesh#36)
  Update bot username to openshift-service-mesh-bot (openshift-service-mesh#35)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#34)
  Add `operator-name` target (openshift-service-mesh#33)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#32)
  Add Debug information when e2e Test run Fails (openshift-service-mesh#31)
  Wrap errors (openshift-service-mesh#28)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#27)
  Use the `quote` function to properly escape CSV annotations (openshift-service-mesh#26)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#24)
  Remove the patch that deleted fixed UIDs from istiod charts (openshift-service-mesh#23)
  Review of field deletions in download-charts.sh (openshift-service-mesh#22)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Apr 17, 2024
Automator: merge upstream changes to openshift-service-mesh/sail-oper…
3814abb 
…ator@main

* upstream/main: (25 commits)
  Fix profiles (openshift-service-mesh#45)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#44)
  Add defaulting for Istio and IstioCNI resources (openshift-service-mesh#43)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#42)
  Fix debug info in e2e tests (openshift-service-mesh#41)
  Update PROJECT file (openshift-service-mesh#40)
  Use exponential backoff for conflicts and gc admission plugin error (openshift-service-mesh#38)
  Handle conflicts on cleanup (openshift-service-mesh#39)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#37)
  Centralize handling of conflicts and other common errors (openshift-service-mesh#25)
  Create namespace if it doesn't exist in README example (openshift-service-mesh#36)
  Update bot username to openshift-service-mesh-bot (openshift-service-mesh#35)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#34)
  Add `operator-name` target (openshift-service-mesh#33)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#32)
  Add Debug information when e2e Test run Fails (openshift-service-mesh#31)
  Wrap errors (openshift-service-mesh#28)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#27)
  Use the `quote` function to properly escape CSV annotations (openshift-service-mesh#26)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#24)
  ...
openshift-service-mesh-bot referenced this pull request in openshift-service-mesh-bot/sail-operator Apr 18, 2024
Automator: merge upstream changes to openshift-service-mesh/sail-oper…
b45495c 
…ator@main

* upstream/main: (31 commits)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#53)
  Update read me for e2e test (openshift-service-mesh#50)
  Add gitleaks to detect secrets (openshift-service-mesh#47)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#51)
  Fix flaky e2e tests (openshift-service-mesh#48)
  Improve e2e debug info (openshift-service-mesh#52)
  Fix profiles (openshift-service-mesh#45)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#44)
  Add defaulting for Istio and IstioCNI resources (openshift-service-mesh#43)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#42)
  Fix debug info in e2e tests (openshift-service-mesh#41)
  Update PROJECT file (openshift-service-mesh#40)
  Use exponential backoff for conflicts and gc admission plugin error (openshift-service-mesh#38)
  Handle conflicts on cleanup (openshift-service-mesh#39)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#37)
  Centralize handling of conflicts and other common errors (openshift-service-mesh#25)
  Create namespace if it doesn't exist in README example (openshift-service-mesh#36)
  Update bot username to openshift-service-mesh-bot (openshift-service-mesh#35)
  Automator: Update dependencies in istio-ecosystem/sail-operator@main (openshift-service-mesh#34)
  Add `operator-name` target (openshift-service-mesh#33)
  ...
asmigala pushed a commit that referenced this pull request Jun 5, 2024
@openshift-merge-bot
Merge pull request #36 from openshift-service-mesh-bot/none-main-merg…
402b838 
…e_upstream_main-38a843ce

Automator: merge upstream changes to openshift-service-mesh/sail-operator@main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luksa luksa luksa approved these changes

Assignees
No one assigned
Labels
ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrfox @istio-testing @jwendell @luksa