Include integration tests in code coverage calculation

[dgn]

This makes sure we're also measuring code coverage for our integration tests. I hope codecov is smart enough to merge the files.

[dgn]

Hmm this takes way too long and is going to eat up our GH actions budget. Will check if we can just upload after running the tests in prow.

/hold

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.22%. Comparing base (8896f99) to head (0ebb03c).
Report is 13 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #427       +/-   ##
===========================================
+ Coverage   60.19%   77.22%   +17.03%     
===========================================
  Files          34       34               
  Lines        1638     1638               
===========================================
+ Hits          986     1265      +279     
+ Misses        600      301      -299     
- Partials       52       72       +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dgn]

Removing the hold. Apparently, as our org is a CNCF org, they should be paying for GitHub Actions. Let's find out :)

[luksa]

So this re-runs all the tests even though we already run them in the other jobs? Isn't there an option to generate a coverage file there and then use that file to generate this report?

[dgn]

So this re-runs all the tests even though we already run them in the other jobs? Isn't there an option to generate a coverage file there and then use that file to generate this report?

I'm looking at removing the prow jobs if we have enough GitHub action budget, and then only running the github actions for unit and integration tests. The problem with generating the profiles in the prow jobs is the following:

• we cannot upload the profiles from the prowjobs because we cannot add secrets to the prow instance
• we could push the profiles to the repo and then just use github actions to upload but it's ~0.5mb to add to the repo

[asmigala]

we cannot add secrets to the prow instance

Why not?

[dgn]

we cannot add secrets to the prow instance

Why not?

people running it won't let us