Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PeerAuth Documentation to indicate that API Dev is frozen #3125

Closed
whitneygriffith opened this issue Mar 13, 2024 · 4 comments · Fixed by #3128
Closed

Update PeerAuth Documentation to indicate that API Dev is frozen #3125

whitneygriffith opened this issue Mar 13, 2024 · 4 comments · Fixed by #3128
Assignees

Comments

@whitneygriffith
Copy link
Contributor

I think we should update the API docs to indicate that the API is also frozen and likely to be replaced in ambient

Originally posted by @louiscryan in #3112 (comment)

@whitneygriffith whitneygriffith self-assigned this Mar 13, 2024
@whitneygriffith
Copy link
Contributor Author

@howardjohn should this just be a comment in both the v1beta1 and v1 resource? How do we set the source of truth for istio.io to be v1?

Also, how do I get the warning box similar to what was done for Istio Operator? https://istio.io/latest/docs/setup/install/operator/

@howardjohn
Copy link
Member

for istio.io, $mode: none is how to opt-out. So the one without that is the source of truth.

warning box is like

{{< warning >}}
blah
{{< /warning >}}

@whitneygriffith
Copy link
Contributor Author

@howardjohn I added $mode: none to v1beta1 and removed it from v1 but when make gen is run it reverses the changes, setting $mode: none on v1. Is this because of sync?

@howardjohn
Copy link
Member

The sync should only apply to lines after the sync-start line, which is after $mode

whitneygriffith added a commit to whitneygriffith/api that referenced this issue Mar 14, 2024
Signed-off-by: whitneygriffith <whitney.griffith16@gmail.com>
istio-testing pushed a commit that referenced this issue Mar 21, 2024
Signed-off-by: whitneygriffith <whitney.griffith16@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants