Add option to set runtime flags #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For istio/istio#37202 I was originally going to use env var hacks - we already have similar for `ISTIO_META` and `XDS_HEADER`. However, envoy runtime vars take the format of `foo.bar_baz=something`. Env vars do not allow `.`, or really any special charecters other than `_`, so we cannot easily use them. Instead, seems better to have an explicit field.
howardjohn
added
the
release-notes-none
howardjohn
requested review from
ericvn,
linsun,
louiscryan,
nrjpoddar and
smawson
as code owners
istio-testing
added
the
size/XS
ericvn
approved these changes
Feb 8, 2022
ramaraochavali
approved these changes
Feb 9, 2022
| @@ -460,6 +460,10 @@ message ProxyConfig { | |||
| // Names starting with `ISTIO_META_` will be included in the generated bootstrap and sent to the XDS server. | |||
| map<string,string> proxy_metadata = 24; | |||
|
|
|||
| // Envoy [runtime configuration](https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/operations/runtime) to set during bootstrapping. | |||
| // This enables setting experimental, unsafe, unsupported, and deprecated features that should be used with extreme caution. | |||
| map<string,string> runtime_values = 37; | |||
There was a problem hiding this comment.
nit: may be runtime_flags?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For istio/istio#37202
I was originally going to use env var hacks - we already have similar
for
ISTIO_METAandXDS_HEADER. However, envoy runtime vars take theformat of
foo.bar_baz=something. Env vars do not allow., or reallyany special charecters other than
_, so we cannot easily use them.Instead, seems better to have an explicit field.