Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layered future: add policy ancestor status #3022

Closed
wants to merge 3 commits into from
Closed

layered future: add policy ancestor status #3022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f956bb3
initial policy ancestor status addition
ilrudie Dec 8, 2023
8009f77
cleanup unused imports
ilrudie Dec 8, 2023
83ac99a
add hide_from_docs tag
ilrudie Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 62 additions & 42 deletions meta/v1alpha1/status.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions meta/v1alpha1/status.pb.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion meta/v1alpha1/status.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@
syntax = "proto3";

import "analysis/v1alpha1/message.proto";

import "google/protobuf/timestamp.proto";

import "type/v1beta1/policy-ancestor-status.proto";

// $title: Istio Status
// $description: Common status field for all istio collections.
// $location: https://istio.io/docs/reference/config/meta/v1beta1/istio-status.html
Expand Down Expand Up @@ -44,6 +45,11 @@ message IstioStatus {
// generation is still in progress. See https://istio.io/latest/docs/reference/config/config-status/ for more info.
// +optional
int64 observed_generation = 3;

// Status from Ancestors
// +optional
// $hide_from_docs
repeated istio.type.v1beta1.PolicyAncestorStatus ancestors = 4;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should remain hidden for now, certainly until its implemented. However its still experimental in GW-API afaik, so we don't want to be ahead of the curve there (in the past, we have done similar and they changed their API. oops).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what exactly hidden means. Do you mean just skip this implementation entirely for now and don't expose a status or do you mean leverage the allow unknown fields in status to write a status without actually adding the experimental fields to the API?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe he meant something like // $hide_from_docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look at this today

}

message IstioCondition {
Expand All @@ -70,3 +76,4 @@ message IstioCondition {
// +optional
string message = 6;
}

121 changes: 121 additions & 0 deletions proto.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39249,6 +39249,12 @@
"id": 3,
"name": "observed_generation",
"type": "int64"
},
{
"id": 4,
"name": "ancestors",
"type": "istio.type.v1beta1.PolicyAncestorStatus",
"is_repeated": true
}
]
},
Expand Down Expand Up @@ -39294,6 +39300,9 @@
},
{
"path": "google/protobuf/timestamp.proto"
},
{
"path": "type/v1beta1/policy-ancestor-status.proto"
}
],
"package": {
Expand Down Expand Up @@ -48304,6 +48313,118 @@
]
}
},
{
"protopath": "type:/:v1beta1:/:policy-ancestor-status.proto",
"def": {
"messages": [
{
"name": "ParentReference",
"fields": [
{
"id": 1,
"name": "group",
"type": "string"
},
{
"id": 2,
"name": "kind",
"type": "string"
},
{
"id": 3,
"name": "namespace",
"type": "string"
},
{
"id": 4,
"name": "name",
"type": "string"
},
{
"id": 5,
"name": "section_name",
"type": "string"
},
{
"id": 6,
"name": "port",
"type": "int32"
}
]
},
{
"name": "PolicyAncestorStatus",
"fields": [
{
"id": 1,
"name": "ancestor_ref",
"type": "ParentReference"
},
{
"id": 2,
"name": "controller_name",
"type": "string"
},
{
"id": 3,
"name": "conditions",
"type": "Condition",
"is_repeated": true
}
]
},
{
"name": "Condition",
"fields": [
{
"id": 1,
"name": "type",
"type": "string"
},
{
"id": 2,
"name": "status",
"type": "string"
},
{
"id": 3,
"name": "observed_generation",
"type": "int64"
},
{
"id": 4,
"name": "last_transition_time",
"type": "google.protobuf.Timestamp"
},
{
"id": 5,
"name": "reason",
"type": "string"
},
{
"id": 6,
"name": "message",
"type": "string"
}
]
}
],
"imports": [
{
"path": "google/protobuf/timestamp.proto"
}
],
"package": {
"name": "istio.type.v1beta1"
},
"options": [
{
"name": "go_package",
"value": "istio.io/api/type/v1beta1"
}
]
}
},
{
"protopath": "type:/:v1beta1:/:selector.proto",
"def": {
Expand Down
Loading