Validation: add documentation and use CEL pre-processor #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/L
ilrudie
reviewed
Oct 23, 2024
Comment on lines
+268
to
+270
| * **default**. Usage: `default(self.x, 'DEF')`. | ||
| * **oneof**. Usage: `oneof(self.x, self.y, self.z)`. This checks that 0 or 1 of these fields is set. | ||
| * **index**. Usage: `self.index({}, x, z, b)`. This does `self.x.z.b` and returns `{}` if any of these is not set. |
There was a problem hiding this comment.
Is the difference 'DEF' must be a concrete value whereas {} could be an expression of some sort?
There was a problem hiding this comment.
Both 'DEF' and {} are just examples of the same thing -- the default value. In one example I return a string and the other an empty object, but there is not a difference.
ilrudie
reviewed
Oct 23, 2024
ilrudie
reviewed
Oct 23, 2024
istio-testing
added
the
needs-rebase
istio-testing
removed
the
needs-rebase
howardjohn
added
release-notes-none
ilrudie
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on istio/tools#3050.
This PR adds support for a new cel pre-processor: https://github.com/howardjohn/celpp.
This avoids the need to write incredibly verbose and error prone boilerplate to workaround limitations in the CEL language.
This PR has a few commits: