Skip to content
This repository was archived by the owner on Jan 23, 2022. It is now read-only.

istio-iptables: Replace socket match with conntrack match #280

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

jrajahalme
Copy link
Contributor

Some kernels, like COS on GKE, are configured without the 'xt_socket'
kernel module that implements the 'socket' match in iptables
rules. Replace the 'socket' match with a 'conntrack' state match that
diverts all established and related packets to the local stack.

Signed-off-by: Jarno Rajahalme jarno@covalent.io

Some kernels, like COS on GKE, are configured without the 'xt_socket'
kernel module that implements the 'socket' match in iptables
rules. Replace the 'socket' match with a 'conntrack' state match that
diverts all established and related packets to the local stack.

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme requested a review from a team as a code owner March 26, 2020 22:32
@istio-policy-bot
Copy link

😊 Welcome @jrajahalme! This is either your first contribution to the Istio cni repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2020
@istio-testing
Copy link
Contributor

Hi @jrajahalme. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 26, 2020
Copy link
Contributor

@rlenglet rlenglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rlenglet rlenglet added the cherrypick/release-1.5 Set this label on a PR to auto-merge it to the release-1.5 branch label Mar 26, 2020
@rlenglet
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 26, 2020
@istio-testing istio-testing merged commit 3adb502 into istio:master Mar 26, 2020
@rlenglet
Copy link
Contributor

/cherrypick-release-1.5

@rlenglet
Copy link
Contributor

/cherrypick release-1.5

@istio-testing
Copy link
Contributor

@rlenglet: new pull request created: #281

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherrypick/release-1.5 Set this label on a PR to auto-merge it to the release-1.5 branch cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants