wasm: restore and fix the Wasm Service. (#440) #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change restores Wasm Service, which was accidentally removed in a bad merge (envoyproxy#321). It also fixes a number of issuses: 1. Wasm Services were started before Cluster Manager was initialized, which crashed Envoy when Wasm Service tried to dispatch a callout. 2. Wasm Services (per-thread) were not stored and they were getting out of scope, so they were immediately destroyed. 3. Wasm Services (singleton) were started twice. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
Is this a blocker for 1.5? It seems so. |
|
Not sure if a blocker, since noone noticed it was removed ~3 months ago... |
fpesce
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores Wasm Service, which was accidentally removed
in a bad merge (#321).
It also fixes a number of issuses:
Wasm Services were started before Cluster Manager was initialized,
which crashed Envoy when Wasm Service tried to dispatch a callout.
Wasm Services (per-thread) were not stored and they were getting
out of scope, so they were immediately destroyed.
Wasm Services (singleton) were started twice.
Signed-off-by: Piotr Sikora piotrsikora@google.com