Cherrypick callback manager improvement fix. #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lambdai PTAL, thanks. |
|
/retest |
|
fails at hot restart at this line. envoy/test/integration/hotrestart_test.sh Line 134 in 3d16207 log, https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_envoy/263/test-tsan_envoy_release-1.6/43 |
|
/retest |
incfly
pushed a commit
to incfly/proxy
that referenced
this pull request
Sep 23, 2020
istio-testing
pushed a commit
to istio/proxy
that referenced
this pull request
Oct 1, 2020
maistra-bot
pushed a commit
to maistra/proxy
that referenced
this pull request
Nov 30, 2020
* [release-1.6] Fix container name as app_container in telemetry v2 (#2907) * fix container name as app_container in telemetry v2 Signed-off-by: gargnupur <gargnupur@google.com> * change containers to container when iterating Signed-off-by: gargnupur <gargnupur@google.com> * change to containers Signed-off-by: gargnupur <gargnupur@google.com> Co-authored-by: gargnupur <gargnupur@google.com> * Fill in unknown for stackdriver metric empty labels (#2910) (#2920) * fill in unknown for empty labels * add comment * format * clean * Update Bazel version (#2928) This should be in sync with the version used by Envoy (https://github.com/istio/envoy/blob/release-1.6/.bazelversion) but was never synchronized. * update release-1.6 envoy sha (#2943) * use antlr 472 (#2984) Include envoy update to use antlr472 * update sha to include istio/envoy#263 (#3023) * Update proxy sha for CVE (#3037) * Fix useragent in stackdriver access log (#3076) (#3083) * Fix useragent in stackdriver access log Signed-off-by: gargnupur <gargnupur@google.com> * fix tests looks like user-agent was just getting ignored in tests before :( Signed-off-by: gargnupur <gargnupur@google.com> * [release-1.6] Update common files (#3104) * Update common sha * Update image version for build container Co-authored-by: Istio Automation <istio.testing@gmail.com> Co-authored-by: gargnupur <gargnupur@google.com> Co-authored-by: Pengyuan Bian <bianpengyuan@google.com> Co-authored-by: Brian Avery <bavery@redhat.com> Co-authored-by: mandarjog <mjog@google.com> Co-authored-by: Jianfei Hu <jianfeih@google.com> Co-authored-by: Nupur Garg <37600866+gargnupur@users.noreply.github.com> Co-authored-by: jacob-delgado <jacob.delgado@volunteers.acasi.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
istio/istio#25909
Cherrypick of the original fix as in envoyproxy#11751.
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]