Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Istio-2020-010 #267

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Fix Istio-2020-010 #267

merged 1 commit into from
Oct 2, 2020

Conversation

brian-avery
Copy link
Member

Fix Istio-2020-010

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@brian-avery brian-avery changed the title Add make clean to reduce sdk image size. (#279) Fix Istio-2020-010 Sep 29, 2020
* Apply patch 2

* patch 3

* Patch 4

* Fixing build failures

Co-authored-by: Dmitri Dolguikh <ddolguik@redhat.com>
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@brian-avery
Copy link
Member Author

/retest test-tsan_envoy_release-1.6

@istio-testing
Copy link

@brian-avery: The /retest command does not accept any targets.
The following commands are available to trigger jobs:

  • /test test-asan_envoy_release-1.6
  • /test test-tsan_envoy_release-1.6
  • /test test-release_envoy_release-1.6

Use /test all to run all jobs.

In response to this:

/retest test-tsan_envoy_release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brian-avery
Copy link
Member Author

/test test-tsan_envoy_release-1.6

@PiotrSikora
Copy link

/test test-asan_envoy_release-1.6

@brian-avery
Copy link
Member Author

@PiotrSikora everything is passing now. Can you please approve it?

@istio-testing istio-testing merged commit b118f52 into istio:release-1.6 Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants