Upgrade the WASM .wat files to match the new version of WAVM we are using. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Squashed and formatted John Plevyak's commits up to 59fadfc. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
into WASM code. Add the ability to dynamically get WASM functions and stubs to dynanmically register callbacks.
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
This allows building Envoy and WAVM with ASAN, since previously both projects exported conflicting __asan_default_options. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
This reverts commit 522dffd. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Note that optimizations are disabled, because optimized WASM module throws wavm.integerDivideByZeroOrOverflow, possibly due to an issue with getFunctionWavm() templates and/or their usage. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
When reading docs it wasn't immediately clear where to configure the Ejection event logging. This change explicitly links to it. Signed-off-by: Liam White <liam@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Description: Use the absl::Stacktrace library along with absl::Symbolize to generate symbolized stack traces without requiring any external tool or post processing. Remove the external dependency on "backward" library. The stack_decode.py script can still be used to obtain additional information, notably file and line numbers. See bazel/README.md for revised usage instructions. Risk Level: Low (may break tooling that interpreted stack traces in logs) Testing: bazel test //test/... , manually examined symbolized backtrace in killed binary. Docs Changes: Changed bazel/README.md Release Notes: Usage details of the stack_decode.py script have changed. Stack traces should include decoded names without it when the binary has appropriate debugging symbols. The script can be used to obtain file and line numbers, see bazel/README.md for details. Signed-off-by: Dan Noé <dpn@google.com>
Signed-off-by: Suhail Patel <me@suhailpatel.com>
…is empty (envoyproxy#5794) Given a filter config {"deprecated_v1":true}, Envoy errors out with a cryptic message about an invalid schema at lines 0-0. This also happens if the required value field contains an empty object of if value is misspelled (including when it contains non-printing characters). This change produces a better error message (and adds tests for the config parsing). *Risk Level*: low *Testing*: added unit test *Docs Changes*: n/a *Release Notes*: n/a Signed-off-by: Stephan Zuercher <zuercher@gmail.com>
*Description*: YAML tools build with bazel cmake from envoyproxy#5218 (it pulls our cc_configure and I think that is the reason) requires newer version of GLIBCXX that CentOS doesn't have. It also speed up build so lets just turn off building them. *Risk Level*: Low *Testing*: CI *Docs Changes*: *Release Notes*: Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This is the same as local getTotalMemory to help with per-thread VMs, though both are short-term workarounds, really. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Add an AccessLog WASM filter and enable it automatically for HTTP Filters. Unify the WASM API and move it to api/wasm/cpp. Change the API calls to have the new naming i.e. "proxy_...".
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* Rename the WASM API files from envoy_ -> proxy_. Remove the atomatic addition of "proxy_" in wasm/wavm/wavm.cc. Add onCreate for new stream contexts and onDelete for stream contexts which are being deleted. Add _emscripten_get_heap_size support for the new version of emscripten/WAVM. Contexts in the WAVM C++ API are now created in onCreate and deleted in onDelete. * Update source/extensions/common/wasm/wasm.h Co-Authored-By: jplevyak <jplevyak@gmail.com>
Including - Set up enscripten environment - With a valid enscripten, build out new .wasm file
Add wasm build instructions to example/wasm
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
* Fix lifetime issue which was causing non-clonable (i.e. V8) WAVM VMs to fail. * Fix WASM tests for the new clonable API. * Use weak pointer to protect timer callback for WASM. * Use shared_ptr for all Common::Wasm::Wasm pointers for consistency and safety with std::enable_shared_from_this(). * Apply PR comment suggestions. * Add comments for PR suggestions.
* fix compile warning on copy ctor of Wasm * reduce header dependencies * address comment * micro refactor, cont * format
…stio#28) * Update WAVM to Wed Feb 20 16:13:27 2019 -0500 to fix memory leak in exception handling.
* Add Exception handling and test for divide by zero exception.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
PiotrSikora
added a commit
that referenced
this pull request
Jun 4, 2019
This prevents a nullptr-dereference when global constructors call host function which calls module function (e.g. malloc). Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the WASM .wat files to match the new version of WAVM we are using.