Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timer work for wasm module #49

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Conversation

bianpengyuan
Copy link

@bianpengyuan bianpengyuan commented Apr 4, 2019

This includes several changes to make timer work for wasm module:

  • instead of copying dispatcher from base wasm, copy the dispatcher from filter construction function. dispatcher from base wasm cannot be used in thread local context due to thread safe check in envoy.
  • remove tick_ function pointer, seems to be usefulness.
  • add ontick and set period into wasm intrinsic api.

@istio-testing
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bianpengyuan
Copy link
Author

@jplevyak Could you please take a look? This is minimal change to make ticker work for wasm module.

@bianpengyuan
Copy link
Author

@jplevyak Could you help me merge this or grant me write access to this repo? Thanks!

@mandarjog mandarjog merged commit 14a36c2 into istio:wasm Apr 10, 2019
rlenglet pushed a commit that referenced this pull request Aug 13, 2019
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
brian-avery added a commit that referenced this pull request Sep 29, 2020
* Patch 1

* Patch 3

* Patch 4

* Remove manual

* Add fix from 1.6
istio-testing pushed a commit that referenced this pull request Oct 2, 2020
* [1.7] Fix CVE-2020-25017 (#47)

* Patch 1

* Patch 3

* Patch 4

* Remove manual

* Revert "[1.7] Fix CVE-2020-25017 (#47)" (#48)

This reverts commit c336863.

* [1.7] Fix CVE-2020-25017 (#49)

* Patch 1

* Patch 3

* Patch 4

* Remove manual

* Add fix from 1.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants