modify sni-proxy.conf snippet for egress to work in kube

[AndreaM12345]

This is to fix #10052

[ ] Configuration Infrastructure
[ x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ x] User Experience
[ ] Developer Infrastructure

[istio-policy-bot]

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been awhile since you've been here. A few things you should know:

• You can learn about how we write and maintain documentation, about our style guidelines,
  and about all the available web site features by visiting Contributing to the Docs.

• In the next few minutes, an automatic preview of your change will be
  built as a full copy of the istio.io website. You can find this preview by clicking on
  the Details link next to the deploy/netlify entry in the Status section of this
  page.

• We care about quality, so we've put in place a number of checks to ensure our documentation
  is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point
  to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
  status section of the page. Click on the Details link to get a list of the problems with your PR.
  Fix those problems and push an update to your PR. This will automatically rerun the tests and
  hopefully this time everything will be perfect.

• Once your changes are accepted and merged into the repository, they will initially show up
  on https://preliminary.istio.io. The changes will be published to https://istio.io
  the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[istio-testing]

Hi @AndreaM12345. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ericvn]

/ok-to-test

[ericvn]

Will probably need the same change in the .md file (see https://github.com/istio/istio.io/blob/master/tests/README.md)

[frankbu]

I think the \ is needed to escape the $ char because of the way the cat command is used to put the contents into the file sni-proxy.conf. That bash command will remove the \.

Btw, you should never modify snips.sh files directly. Instead, go to the corresponding .md file (wildcard-egress-hosts/index.md in this case), make the change there, and then run make gen to regen the snips file. The way that snips are generated from md files is described here: https://github.com/istio/istio.io/blob/master/tests/README.md

[AndreaM12345]

@googlebot I signed it!

[AndreaM12345]

/retest

[istio-testing]

@AndreaM12345: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[istio-testing]

@AndreaM12345: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
doc.test.multicluster_istio.io	cf0160c	link	true	/test doc.test.multicluster
doc.test.profile_none_istio.io	cf0160c	link	true	/test doc.test.profile_none
doc.test.profile_demo_istio.io	cf0160c	link	true	/test doc.test.profile_demo
doc.test.profile_default_istio.io	cf0160c	link	true	/test doc.test.profile_default
doc.test.profile_minimal_istio.io	cf0160c	link	true	/test doc.test.profile_minimal
doc.test.profile-default_istio.io	cf0160c	link	true	/test doc.test.profile-default
doc.test.profile-none_istio.io	cf0160c	link	true	/test doc.test.profile-none
doc.test.profile-demo_istio.io	cf0160c	link	true	/test doc.test.profile-demo
doc.test.profile-minimal_istio.io	cf0160c	link	true	/test doc.test.profile-minimal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[craigbox]

@AndreaM12345 want to come back to this PR with the benefit of experience? :)

[frankbu]

This documentation has been removed long ago, so we can close this.