-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs about configuring faults and retry/timeout on the same VirtualService #10781
Add docs about configuring faults and retry/timeout on the same VirtualService #10781
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @denniseffing. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
789e0bb
to
001d303
Compare
@denniseffing please sign CLA, thx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
001d303
to
30cab98
Compare
/retest |
|
||
This works because this way the retry policy is configured for the client proxy while the fault | ||
injection is configured for the upstream proxy. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but it might be worth mentioning the alternative of moving the retry policy to the virtual service of a client service, if that makes sense? For example, in bookinfo, it would probably be reasonable to put the retry in the reviews
service, for fault injection in the ratings
service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is true. I didn't mention this specifically because configuring retries and faults on different virtual services is quite the obvious workaround but not always applicable. I'll see if I can come up with a sentence or two that mentions this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Just a couple of minor suggestions.
30cab98
to
cd09a72
Compare
@denniseffing Still waiting on you satisfying the CLA bot. |
Yes, sorry! I made the "mistake" of asking internally which one we would like to sign. 😅 I honestly didn't expect that much delay, my apologies. I will sign them soon! |
VirtualService Signed-off-by: Dennis Effing <dennis.effing@codecentric.de>
0ba481e
to
f72e183
Compare
@ericvn I signed the CLA and rebased the changes. |
This PR adds documentation about a common issue when testing resilience mechanisms like retries and timeouts using the Istio fault injection: The resilience mechanisms don't work when faults and retrys/timeouts are configured on the same
VirtualService
. See istio/istio#13705 for more details.I'm currently ironing out the details for signing the CLA as a codecentric employee, I expect that to be done sometime next week but I wanted to open this PR to collect some feedback.