add otel telemetry doc #10977

zirain · 2022-02-26T08:34:35Z

Please provide a description for what this PR is for.

add otel telemetry doc

istio-testing · 2022-02-26T08:34:59Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

zirain · 2022-02-27T11:37:09Z

/test all

content/en/docs/tasks/observability/logs/otel-provider/index.md

douglas-reid

Looks pretty good. Mostly nits. Thanks for tackling this!

content/en/docs/tasks/observability/logs/otel-provider/index.md

zirain · 2022-03-05T03:31:02Z

/test doc.test.profile_default_istio.io

content/en/docs/tasks/observability/logs/otel-provider/index.md

craigbox · 2022-03-07T01:02:52Z

Let me know if this is good to go and I can approve.

zirain · 2022-03-07T01:11:30Z

Let me know if this is good to go and I can approve.

there's something with the test part I need to confirm with @douglas-reid , I'll ping you once it's ready to go.
thanks again.

zirain · 2022-03-09T14:25:35Z

/test doc.test.profile_demo_istio.io

ericvn · 2022-03-09T14:26:45Z

/test doc.test.profile_demo_istio.io

ericvn · 2022-03-09T22:57:27Z

received:
"2022-03-09T12:35:01.500Z	info	builder/receivers_builder.go:68	Receiver is starting...	{"kind": "receiver", "name": "otlp"}
2022-03-09T12:35:01.500Z	info	otlpreceiver/otlp.go:68	Starting GRPC server on endpoint 0.0.0.0:4317	{"kind": "receiver", "name": "otlp"}
2022-03-09T12:35:01.500Z	info	otlpreceiver/otlp.go:86	Starting HTTP server on endpoint 0.0.0.0:4318	{"kind": "receiver", "name": "otlp"}
2022-03-09T12:35:01.500Z	info	otlpreceiver/otlp.go:141	Setting up a second HTTP listener on legacy endpoint 0.0.0.0:55681	{"kind": "receiver", "name": "otlp"}
2022-03-09T12:35:01.500Z	info	otlpreceiver/otlp.go:86	Starting HTTP server on endpoint 0.0.0.0:55681	{"kind": "receiver", "name": "otlp"}
2022-03-09T12:35:01.501Z	info	builder/receivers_builder.go:73	Receiver started.	{"kind": "receiver", "name": "otlp"}
2022-03-09T12:35:01.501Z	info	service/telemetry.go:92	Setting up own telemetry...
2022-03-09T12:35:01.505Z	info	service/telemetry.go:116	Serving Prometheus metrics	{"address": ":8888", "level": "basic", "service.instance.id": "ae125cf2-d80b-4252-8a1f-84d407065909", "service.version": "latest"}
2022-03-09T12:35:01.505Z	info	service/collector.go:230	Starting otelcol...	{"Version": "0.38.0", "NumCPU": 16}
2022-03-09T12:35:01.505Z	info	service/collector.go:132	Everything is ready. Begin running and processing data."
expected:
"outbound|8000||httpbin.default.svc.cluster.local"

zirain · 2022-03-10T02:40:12Z

/test doc.test.profile_demo_istio.io

zirain · 2022-03-10T06:27:57Z

/test doc.test.profile_demo_istio.io

zirain · 2022-03-11T05:38:05Z

@douglas-reid @ericvn fixed the test.sh PTAL.

ericvn · 2022-03-14T20:33:55Z

content/en/docs/tasks/observability/logs/otel-provider/index.md

+\"%REQ(:AUTHORITY)%\" \"%UPSTREAM_HOST%\" %UPSTREAM_CLUSTER% %UPSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_LOCAL_ADDRESS% %DOWNSTREAM_REMOTE_ADDRESS% %REQUESTED_SERVER_NAME% %ROUTE_NAME%\n
+{{< /text >}}
+
+The following table shows an example using the default access log format for a request sent from `sleep` to `httpbin`:


On my computer, this table is very wide and overwrites the right hand column.

Other than the table, this LGTM.

this table come from another page, and I do not change anything, I have no idea about what's happen on your compute.
can we merged this first, let's see what happen to https://preliminary.istio.io/?

https://deploy-preview-10977--preliminary-istio.netlify.app/latest/docs/tasks/observability/logs/otel-provider/

I'm OK with merging it and fixing the rendering bug separately. (I don't think you've done anything wrong.)

the page looks good.

Here's an example on what I see. As Craig mentioned, we can fix this rendering later.

I think there's same issue on page https://istio.io/latest/docs/tasks/observability/logs/access-log/
let's merge this PR first? I will fix them both later this week.

craigbox · 2022-03-15T19:48:56Z

Is it possible to cherrypick this into 1.13 to get the doc live now, or does it depend on package changes in master?

ericvn · 2022-03-15T21:36:16Z

The sample exists in 1.13. Let's give it a try.

ericvn · 2022-03-15T21:36:31Z

/cherry-pick release-1.13

istio-testing · 2022-03-15T21:38:09Z

@ericvn: new pull request created: #11058

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Feb 26, 2022

istio-policy-bot added the kind/docs label Feb 26, 2022

istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 26, 2022

zirain added the area/extensions and telemetry label Feb 26, 2022

zirain force-pushed the otel-logging branch 3 times, most recently from 11d5c90 to 88aa254 Compare February 27, 2022 11:36

zirain commented Feb 28, 2022

View reviewed changes

content/en/docs/tasks/observability/logs/otel-provider/index.md Outdated Show resolved Hide resolved

zirain marked this pull request as ready for review March 1, 2022 00:23

zirain requested review from a team as code owners March 1, 2022 00:23

istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Mar 1, 2022

zirain mentioned this pull request Mar 1, 2022

Ability to send traces to AWS X-ray istio/istio#36599

Closed

douglas-reid reviewed Mar 4, 2022

View reviewed changes

craigbox reviewed Mar 6, 2022

View reviewed changes

zirain mentioned this pull request Mar 9, 2022

add otel provider in demo profile istio/istio#37819

Merged

zirain force-pushed the otel-logging branch from 469bbca to a01dc3b Compare March 10, 2022 02:00

zirain force-pushed the otel-logging branch 2 times, most recently from 43087f8 to d10ef1a Compare March 10, 2022 10:34

zirain force-pushed the otel-logging branch 2 times, most recently from ee4accf to f8632d6 Compare March 11, 2022 03:32

zirain added 7 commits March 14, 2022 08:10

add otel telemetry doc

a733c58

fix nit

1876d78

fix gen

c59783f

update content

ae73563

remove patch meshconfig

9378076

fix test.sh

245f52e

fix probability of failure

06489ec

zirain force-pushed the otel-logging branch from f8632d6 to 06489ec Compare March 14, 2022 00:11

ericvn reviewed Mar 14, 2022

View reviewed changes

douglas-reid approved these changes Mar 15, 2022

View reviewed changes

ericvn approved these changes Mar 15, 2022

View reviewed changes

istio-testing merged commit 7a90100 into istio:master Mar 15, 2022

istio-testing mentioned this pull request Mar 15, 2022

[release-1.13] add otel telemetry doc #11058

Merged

zirain deleted the otel-logging branch March 16, 2022 00:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add otel telemetry doc #10977

add otel telemetry doc #10977

zirain commented Feb 26, 2022 •

edited

Loading

istio-testing commented Feb 26, 2022

zirain commented Feb 27, 2022

douglas-reid left a comment

zirain commented Mar 5, 2022

craigbox commented Mar 7, 2022

zirain commented Mar 7, 2022

zirain commented Mar 9, 2022

ericvn commented Mar 9, 2022

ericvn commented Mar 9, 2022

zirain commented Mar 10, 2022

zirain commented Mar 10, 2022

zirain commented Mar 11, 2022

ericvn Mar 14, 2022

ericvn Mar 14, 2022

ericvn Mar 14, 2022

zirain Mar 15, 2022

craigbox Mar 15, 2022

zirain Mar 15, 2022

ericvn Mar 15, 2022

zirain Mar 15, 2022 •

edited

Loading

craigbox commented Mar 15, 2022

ericvn commented Mar 15, 2022

ericvn commented Mar 15, 2022

istio-testing commented Mar 15, 2022

add otel telemetry doc #10977

add otel telemetry doc #10977

Conversation

zirain commented Feb 26, 2022 • edited Loading

istio-testing commented Feb 26, 2022

zirain commented Feb 27, 2022

douglas-reid left a comment

Choose a reason for hiding this comment

zirain commented Mar 5, 2022

craigbox commented Mar 7, 2022

zirain commented Mar 7, 2022

zirain commented Mar 9, 2022

ericvn commented Mar 9, 2022

ericvn commented Mar 9, 2022

zirain commented Mar 10, 2022

zirain commented Mar 10, 2022

zirain commented Mar 11, 2022

ericvn Mar 14, 2022

Choose a reason for hiding this comment

ericvn Mar 14, 2022

Choose a reason for hiding this comment

ericvn Mar 14, 2022

Choose a reason for hiding this comment

zirain Mar 15, 2022

Choose a reason for hiding this comment

craigbox Mar 15, 2022

Choose a reason for hiding this comment

zirain Mar 15, 2022

Choose a reason for hiding this comment

ericvn Mar 15, 2022

Choose a reason for hiding this comment

zirain Mar 15, 2022 • edited Loading

Choose a reason for hiding this comment

craigbox commented Mar 15, 2022

ericvn commented Mar 15, 2022

ericvn commented Mar 15, 2022

istio-testing commented Mar 15, 2022

zirain commented Feb 26, 2022 •

edited

Loading

zirain Mar 15, 2022 •

edited

Loading