Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update netlify hugo #11193

Merged
merged 1 commit into from
Apr 20, 2022
Merged

update netlify hugo #11193

merged 1 commit into from
Apr 20, 2022

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Apr 19, 2022

resolve #11190

@Arhell Arhell requested a review from a team as a code owner April 19, 2022 11:58
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2022
@Arhell Arhell marked this pull request as draft April 19, 2022 14:09
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 19, 2022
@ericvn
Copy link
Contributor

ericvn commented Apr 19, 2022

I did test this manually, using a locally built build-tools image with an updated Hugo:

> IMG=ericvn/build-tools:master-latest make serve
Start building sites …
hugo v0.97.3-078053a43d746a26aa3d48cf1ec7122ae78a9bb4 linux/amd64 BuildDate=2022-04-18T17:22:19Z VendorInfo=gohugoio

                   | EN  | PT-BR | ZH
-------------------+-----+-------+------
  Pages            | 816 |     4 | 708
  Paginator pages  |   0 |     0 |   0
  Non-page files   | 424 |     0 | 341
  Static files     | 214 |   214 | 214
  Processed images |   0 |     0 |   0
  Aliases          |   1 |     0 |   0
  Sitemaps         |   2 |     1 |   1
  Cleaned          |   0 |     0 |   0

Built in 28651 ms

A quick check and nothing seemed broken.

@Arhell Arhell marked this pull request as ready for review April 19, 2022 21:20
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 19, 2022
@Arhell Arhell requested a review from ericvn April 19, 2022 21:20
@Arhell
Copy link
Member Author

Arhell commented Apr 19, 2022

/retest

@craigbox
Copy link
Contributor

Anything in particular this version fixes or that we should watch out for in testing?
Or is this just for being up to date?

@Arhell
Copy link
Member Author

Arhell commented Apr 20, 2022

Yes, just up to date.

@craigbox
Copy link
Contributor

Looking at https://github.com/gohugoio/hugo/releases, there's been a bunch of 0.97 point releases in the last few days. I think it might be best to leave this sit for a week or so and see if they find any other major bugs. Would that be OK, @Arhell ?

@Arhell
Copy link
Member Author

Arhell commented Apr 20, 2022

Looking at https://github.com/gohugoio/hugo/releases, there's been a bunch of 0.97 point releases in the last few days. I think it might be best to leave this sit for a week or so and see if they find any other major bugs. Would that be OK, @Arhell ?

There were already bugs in 0.97.2. There were problems with the build.
I checked, everything works + I did not find any bugs for our site.

craigbox
craigbox approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@craigbox craigbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we can always upgrade/downgrade I guess.

@Arhell
Copy link
Member Author

Arhell commented Apr 20, 2022

/retest

@craigbox
Copy link
Contributor

/retest-required

@ericvn
Copy link
Contributor

ericvn commented Apr 20, 2022

Not sure why these tests are failing. I'll try and look later today.

@ericvn
Copy link
Contributor

ericvn commented Apr 20, 2022

/retest

@istio-testing istio-testing merged commit 7790b35 into istio:master Apr 20, 2022
@Arhell Arhell deleted the upd-hugo branch April 20, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbox craigbox craigbox approved these changes

@ericvn ericvn Awaiting requested review from ericvn

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update netlify hugo
4 participants
@Arhell @ericvn @craigbox @istio-testing