Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update content/en/about/faq/security/verify-mtls-encryption.md #11248

Merged
merged 1 commit into from
May 2, 2022
Merged

Update content/en/about/faq/security/verify-mtls-encryption.md #11248

merged 1 commit into from
May 2, 2022

Conversation

kinzhi
Copy link
Member

@kinzhi kinzhi commented Apr 30, 2022

Please provide a description for what this PR is for.

And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.

  • Configuration Infrastructure
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Policies and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure

@kinzhi kinzhi requested a review from a team as a code owner April 30, 2022 16:42
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2022
@istio-testing
Copy link
Contributor

Hi @kinzhi. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kinzhi kinzhi changed the title zh-translation:Update content/en/about/faq/security/verify-mtls-encryption.md Update content/en/about/faq/security/verify-mtls-encryption.md Apr 30, 2022
@kinzhi
Copy link
Member Author

kinzhi commented Apr 30, 2022

/ok-to-test

@istio-testing
Copy link
Contributor

@kinzhi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kebe7jun
Copy link
Member

kebe7jun commented May 2, 2022

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels May 2, 2022
@craigbox
Copy link
Contributor

craigbox commented May 2, 2022

validated URLs. thanks!

@istio-testing istio-testing merged commit 2ec1a66 into istio:master May 2, 2022
@kinzhi kinzhi mentioned this pull request May 2, 2022
Merged
5 tasks
dhawton pushed a commit to dhawton/istio.io that referenced this pull request May 6, 2022
@kinzhi @dhawton
zh-translation:Update content/en/about/faq/security/verify-mtls-encry…
56f1437 
…ption.md (istio#11248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbox craigbox craigbox approved these changes

Assignees
No one assigned
Labels
kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kinzhi @istio-testing @kebe7jun @craigbox @istio-policy-bot