-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Egress Gateway, istioctl command wrap with dquotes #14632
Egress Gateway, istioctl command wrap with dquotes #14632
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
The committers listed above are authorized under a signed CLA. |
Hi @Seokyun-Ha. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you want to add this? The current commands are working for me. I think this may be your shell issue.
Please sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
When I use previous command, I got parsing error because of square brackets On other pages in Examples:
I think it's more safe to wrap with quotes/dquote. |
Also, I've signed EasyCLA. Thanks for letting me know 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Seokyun-Ha!
Description
Wrap command parameters with dquotes, because of square brackets
[0]
. For me, it causes parsing error.Reviewers