-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new pattern SERVICE_NAME variable for stat prefix #15449
base: master
Are you sure you want to change the base?
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @Ferdudas97. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Ferdudas97, you'll have to make the change here: https://github.com/istio/api/blob/master/mesh/v1alpha1/config.proto (after your code PR is merged). HTML docs (like this one) are generated automatically from the .proto files in API repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@Arhell this PR should be closed/discarded as we never make direct changes to autogenerated HTML files. |
Description
Added new variable %SERVICE_NAME% for inboundClusterStatName/outboundClusterStatName
Reviewers