Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add introduction and glossary for gateway API #15511

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ayush9026
Copy link

@Ayush9026 Ayush9026 commented Aug 3, 2024

Description

This issue solve this PR #15165 added an introduction and glossary for Gateway API for Istio users .

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@Ayush9026 Ayush9026 requested review from a team as code owners August 3, 2024 13:56
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test labels Aug 3, 2024
@istio-testing
Copy link
Contributor

Hi @Ayush9026. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

The file archive/v0.8/index.html was deleted because changes were made to it by mistake. This commit removes the file to correct the unintended modifications and maintain the repository's intended state.
@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 3, 2024
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 4, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should not be removed.

Copy link
Author

@Ayush9026 Ayush9026 Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @craigbox sir,

The changes to archive/v0.8/index.html were unintentional.I will restore the file to its original state and ensure that the unintended changes are corrected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the names of other directories here to learn how pages should be named (no spaces, no capital letters)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @craigbox! sir I’ll fix the naming issues.

content/en/docs/reference/glossary/gateway-api-glossary.md Outdated Show resolved Hide resolved
@craigbox
Copy link
Contributor

craigbox commented Aug 5, 2024

Hi @Ayush9026,

This looks like LLM-generated content which is being submitted in order to influence selection for an upcoming LFX mentorship. Am I wrong?

Please refer back here, especially the section reading "Jumping into issues in the community is a great, but it is very obvious to maintainers when someone is doing it to try to win a paid mentorship."

@istio-testing
Copy link
Contributor

@Ayush9026: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
lint_istio.io 2c06280 link true /test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Ayush9026
Copy link
Author

Hi @Ayush9026,

This looks like LLM-generated content which is being submitted in order to influence selection for an upcoming LFX mentorship. Am I wrong?

Please refer back here, especially the section reading "Jumping into issues in the community is a great, but it is very obvious to maintainers when someone is doing it to try to win a paid mentorship."

Hi sir,

I understand your concern. I am currently working on freelance projects, which involve reviewing and writing content, including an blog. To ensure quality, I structured my content and checked for spelling mistakes. If needed, I can share the template provided for this work.

@craigbox craigbox added the do-not-merge Block automatic merging of a PR. label Aug 6, 2024
@craigbox
Copy link
Contributor

craigbox commented Dec 9, 2024

Hi @Ayush9026,

Do you intend to drive this PR through to mergable, or should we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Block automatic merging of a PR. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants