Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix command execution issue and tcpdump port error in task mtls-migration #15513

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kibaamor
Copy link
Contributor

@kibaamor kibaamor commented Aug 5, 2024

Two issues in task mtls/migration(Mutual TLS Migration/双向 TLS 迁移):

  1. Some commands will fail if executed in the zsh shell.
  2. Tcpdump port should be 8080 instead of 80.

Description

  1. All commands for testing sending requests between namespaces will fail if it was executed in the zsh shell.
$ for from in "foo" "bar" "legacy"; do for to in "foo" "bar"; do kubectl exec "$(kubectl get pod -l app=sleep -n ${from} -o jsonpath={.items..metadata.name})" -c sleep -n ${from} -- curl http://httpbin.${to}:8000/ip -s -o /dev/null -w "sleep.${from} to httpbin.${to}: %{http_code}\n"; done; done
sleep.foo to httpbin.foo: 000
command terminated with exit code 3
sleep.foo to httpbin.bar: 000
command terminated with exit code 3
sleep.bar to httpbin.foo: 000
command terminated with exit code 3
sleep.bar to httpbin.bar: 000
command terminated with exit code 3
sleep.legacy to httpbin.foo: 000
command terminated with exit code 3
sleep.legacy to httpbin.bar: 000
command terminated with exit code 3

Like in task Authentication Policy, I suggest that the test URLs should be enclosed in double quotes.

- ... curl http://httpbin.${to}:8000/ip -s ...
+ ... curl "http://httpbin.${to}:8000/ip" -s ...
  1. The tcpdump listening port should be 8080 instead of 80, because httpbin container is listening port 8080.
$ cat samples/httpbin/httpbin.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: httpbin
spec:
  template:
    spec:
      containers:
      - image: docker.io/kong/httpbin
        name: httpbin
        ports:
        - containerPort: 8080
...

Based on the description above, I created this PR to fix these issues in both the English and Chinese documents.
Please take a look.
Thanks.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@kibaamor kibaamor requested review from a team as code owners August 5, 2024 15:49
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Aug 5, 2024
@istio-testing
Copy link
Contributor

Hi @kibaamor. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhawton
Copy link
Member

dhawton commented Aug 5, 2024

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Aug 5, 2024
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 12, 2024
@istio-testing
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs needs-rebase Indicates a PR needs to be rebased before being merged ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants