-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit name of ingress gateway install #15536
base: release-1.22
Are you sure you want to change the base?
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @tesla59. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Nishant Singh <nishant@heim.id>
This has been requested before and been blocked: #13516 (review) cc: @howardjohn since you were the blocker previously. |
While i agree that the user should be aware of how the selector is working, i think we should mention it in docs then. if installing using istioctl sets |
👍 |
/ok-to-test You're going to need to run |
Signed-off-by: Nishant Singh <nishant@heim.id>
@dhawton i have run |
@tesla59: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This PR updated release name of the istio gateway installed using helm. While in the gateway docs the release name is
istio-ingressgateway
, in the helm installation doc for istio the release name isistio-ingress
.Due to this change, anyone following the helm installation doc will have gateway label as
istio: gateway
instead ofistio: ingressgateway
. Other installation method sets the labels asistio: ingressgateway
and the other docs also assume the label to beistio: ingressgateway
.Reviewers