fix filter removal for http filter #37903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
istio-testing
added
the
size/M
ramaraochavali
commented
Mar 14, 2022
| @@ -512,6 +520,7 @@ func patchHTTPFilters(patchContext networking.EnvoyFilter_PatchContext, | |||
| if removedFilters.Contains(filter.Name) { | |||
| continue | |||
| } | |||
| tempArray = append(tempArray, filter) | |||
There was a problem hiding this comment.
This is the actual fix. Not adding to tempArray. Rest of the changes are format changes.
There was a problem hiding this comment.
Can you add a test? Lack of ut cause this happen.
howardjohn
reviewed
Mar 14, 2022
Comment on lines
538
to
539
| httpFilter *hcm.HttpFilter, | ||
| ) bool { |
There was a problem hiding this comment.
can you use the older gofumpt to avoid noise in PRs?
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
network filter removal has test but not http filter removal. Added a test for it. PTAL. |
istio-testing
added
size/S
howardjohn
approved these changes
Mar 16, 2022
|
In response to a cherrypick label: new pull request created: #37961 |
aryan16
pushed a commit
to aryan16/istio
that referenced
this pull request
Mar 28, 2022
* fix filter removal for http filter Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * add test and release notes Signed-off-by: Rama Chavali <rama.rao@salesforce.com> * add test and release notes Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug in this PR #36404. Http filter removal does not work correctly.
Please check any characteristics that apply to this pull request.