Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]update golangci rule #2144

Closed
wants to merge 1 commit into from
Closed

[WIP]update golangci rule #2144

wants to merge 1 commit into from

Conversation

zirain
Copy link
Member

@zirain zirain commented Sep 22, 2022 •
edited
Loading

DO NOT MERGE, just for test

@zirain zirain requested a review from a team as a code owner September 22, 2022 09:07
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2022
@zirain
Copy link
Member Author

zirain commented Sep 22, 2022

add DNM as we should change code first

@zirain zirain added the do-not-merge Block automatic merging of a PR. label Sep 22, 2022
@zirain zirain mentioned this pull request Sep 22, 2022
Merged
@zirain
Copy link
Member Author

zirain commented Sep 22, 2022

replaced by istio/common-files#672.

@zirain zirain closed this Sep 22, 2022
@zirain zirain deleted the golangci-lint branch September 22, 2022 09:28
@zirain zirain restored the golangci-lint branch September 22, 2022 11:40
@zirain zirain reopened this Sep 22, 2022
@zirain zirain changed the title update golangci rule [WIP]update golangci rule Sep 22, 2022
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Sep 22, 2022
@zirain zirain mentioned this pull request Sep 22, 2022
Merged
@ericvn
Copy link
Contributor

ericvn commented Sep 22, 2022

replaced by #2147

@ericvn ericvn closed this Sep 22, 2022
@zirain zirain deleted the golangci-lint branch September 23, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. do-not-merge Block automatic merging of a PR. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zirain @ericvn @istio-testing