Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci-lint to 1.63.4 #3108

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

dgn
Copy link
Contributor

@dgn dgn commented Jan 7, 2025

1.63.1 has a few bugs that affected us (especially golangci/golangci-lint#5285).

1.63.1 has a few bugs that affected us (especially
golangci/golangci-lint#5285).
@dgn dgn requested a review from a team as a code owner January 7, 2025 13:25
@istio-policy-bot
Copy link

😊 Welcome @dgn! This is either your first contribution to the Istio tools repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 7, 2025
Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix the test failure?

@dgn
Copy link
Contributor Author

dgn commented Jan 7, 2025

Can you also fix the test failure?

#3107 (which in turn requires istio/common-files#1130)

@dgn
Copy link
Contributor Author

dgn commented Jan 7, 2025

/retest

@istio-testing istio-testing merged commit 6e3c5ef into master Jan 7, 2025
8 checks passed
@istio-testing istio-testing deleted the update-golangci-lint branch January 7, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants