Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit .unwrap and .expect usages; replace with proper error handling where needed. #9

Closed
howardjohn opened this issue Oct 19, 2022 · 3 comments
Closed

Audit .unwrap and .expect usages; replace with proper error handling where needed. #9

howardjohn opened this issue Oct 19, 2022 · 3 comments
Assignees
@briansonnenberg
Labels
area/traffic-flow Area: Traffic Flow OSS Alpha All workitems/features needed to graduate zTunnel to Alpha status in OSS repo P0
Milestone
M1: Productionali...

Comments

@howardjohn
Copy link
Member

No description provided.

@howardjohn howardjohn added area/traffic-flow Area: Traffic Flow P0 labels Nov 17, 2022
@howardjohn howardjohn added this to the M1: Productionalization milestone Nov 17, 2022
@SkyfireFrancisZ SkyfireFrancisZ added the OSS Alpha All workitems/features needed to graduate zTunnel to Alpha status in OSS repo label Dec 16, 2022
@yuval-k
Copy link
Contributor

yuval-k commented Dec 22, 2022

to that end, clippy can help cargo clippy -- -D clippy::expect_used -D clippy::panic -D clippy::unwrap_used

@SkyfireFrancisZ SkyfireFrancisZ moved this to Up Next in ztunnel tracking Jan 17, 2023
@SkyfireFrancisZ SkyfireFrancisZ moved this from Up Next to In Progress in ztunnel tracking Jan 30, 2023
@SkyfireFrancisZ
Copy link

started working on the PR

istio-testing pushed a commit that referenced this issue Feb 8, 2023
@briansonnenberg
Issue #9: Handled some expects()/unwraps() (#380)
e2f27d6 
* Handled some expects()/unwraps()

* Box workload in variant
@briansonnenberg briansonnenberg moved this from In Progress to Done in ztunnel tracking Feb 8, 2023
howardjohn added a commit to howardjohn/ztunnel that referenced this issue Apr 4, 2024
@howardjohn
handle various usage of unwrap to proper error handling
2a84e33 
For istio#9
@howardjohn howardjohn mentioned this issue Apr 4, 2024
Merged
istio-testing pushed a commit that referenced this issue Apr 7, 2024
@howardjohn
handle various usage of unwrap to proper error handling (#880)
961eb56 
For #9
@ilrudie ilrudie mentioned this issue Aug 1, 2024
Open
@howardjohn
Copy link
Member Author

Move to #1245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briansonnenberg briansonnenberg

Labels
area/traffic-flow Area: Traffic Flow OSS Alpha All workitems/features needed to graduate zTunnel to Alpha status in OSS repo P0
Projects
ztunnel tracking
Status: Done
Milestone
M1: Productionalization
Development

No branches or pull requests
4 participants
@yuval-k @howardjohn @SkyfireFrancisZ @briansonnenberg