auth: async-ify and clean up #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Interceptor usage in tonic is not really useful for us since we make our own client for other reasons (tls, etc) so we can already easily insert some headers. It also makes us do some awkward DefaultIncoming stuff, and doesn't allow async. This moves the auth to async, which is generally a good idea and more flexible, and cleans up some of the cruft
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/L
bleggett
approved these changes
Sep 19, 2024
antonioberben
pushed a commit
to antonioberben/ztunnel
that referenced
this pull request
Oct 1, 2024
The Interceptor usage in tonic is not really useful for us since we make our own client for other reasons (tls, etc) so we can already easily insert some headers. It also makes us do some awkward DefaultIncoming stuff, and doesn't allow async. This moves the auth to async, which is generally a good idea and more flexible, and cleans up some of the cruft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Interceptor usage in tonic is not really useful for us since we make
our own client for other reasons (tls, etc) so we can already easily
insert some headers. It also makes us do some awkward DefaultIncoming
stuff, and doesn't allow async.
This moves the auth to async, which is generally a good idea and more
flexible, and cleans up some of the cruft