Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty print config #652

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Pretty print config #652

merged 3 commits into from
Aug 11, 2023

Conversation

Stevenjin8
Copy link
Contributor

Pretty print ztunnel config dump as per #638.
Default tab size is 2 spaces.

@Stevenjin8 Stevenjin8 requested a review from a team as a code owner August 10, 2023 22:44
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 10, 2023
@Stevenjin8 Stevenjin8 marked this pull request as draft August 10, 2023 23:00
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Aug 10, 2023
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@Stevenjin8 Stevenjin8 added the do-not-merge/hold Block automatic merging of a PR. label Aug 10, 2023
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2023
@Stevenjin8 Stevenjin8 marked this pull request as ready for review August 10, 2023 23:42
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Aug 10, 2023
@Stevenjin8 Stevenjin8 added do-not-merge/hold Block automatic merging of a PR. and removed do-not-merge/hold Block automatic merging of a PR. labels Aug 10, 2023
@Stevenjin8 Stevenjin8 requested a review from howardjohn August 10, 2023 23:42
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 10, 2023
@hzxuzhonghu hzxuzhonghu removed the do-not-merge/hold Block automatic merging of a PR. label Aug 11, 2023
@istio-testing istio-testing merged commit 66a5516 into istio:master Aug 11, 2023
hanxiaop
hanxiaop reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@hanxiaop hanxiaop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Stevenjin8 Stevenjin8 self-assigned this Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiaop hanxiaop hanxiaop left review comments

@hzxuzhonghu hzxuzhonghu hzxuzhonghu approved these changes

@howardjohn howardjohn Awaiting requested review from howardjohn

Assignees

@Stevenjin8 Stevenjin8

Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Stevenjin8 @howardjohn @hzxuzhonghu @hanxiaop @istio-testing