Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gperftools, use jemalloc #865

Merged
merged 6 commits into from
Apr 3, 2024
+220 −111
Merged

Remove gperftools, use jemalloc #865

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
10d19a6
Remove gperftools, use jemalloc
bleggett Apr 2, 2024
8eca3fa
Throw this in
bleggett Apr 2, 2024
3e350d8
Lint
bleggett Apr 2, 2024
d66fb52
Remove leftover cruft
bleggett Apr 2, 2024
05f2a53
Lints
bleggett Apr 3, 2024
acb5f46
lints part deux
bleggett Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
169 changes: 134 additions & 35 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ rust-version = "1.65"

[features]
default = ["tls-ring"]
gperftools = ["dep:gperftools"]
jemalloc = ["dep:tikv-jemallocator", "dep:jemalloc_pprof"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we default to jemalloc? and/or unconditionally use it? or do we think we need more performance testing?

Copy link
Contributor Author

@bleggett bleggett Apr 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I would rather not, this is just a drop-in replacement for what we had before that works, but we can certainly look into doing that later, yeah.

I think the impact will be minimal tho, I just haven't tried it myself.

console = ["dep:console-subscriber"]
tls-boring = ["dep:boring", "dep:boring-sys", "boring-rustls-provider/fips-only", "ztunnel/tls-boring"]
tls-ring = ["dep:ring", "rustls/ring", "dep:rcgen", "ztunnel/tls-ring"]
Expand Down Expand Up @@ -48,7 +48,8 @@ duration-str = "0.7"
futures = "0.3"
futures-core = "0.3"
futures-util = "0.3"
gperftools = { version = "0.2", features = ["heap"], optional = true }
jemalloc_pprof = { version = "0.1.0", optional = true }
tikv-jemallocator = { version = "0.5.4", features = ["profiling", "unprefixed_malloc_on_supported_platforms"], optional = true }
hashbrown = "0.14"
hickory-client = "0.24"
hickory-proto = "0.24"
Expand Down
Loading