Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P4-4131: missing Send Msg confirmation box #279

Merged
merged 8 commits into from
Dec 2, 2022
Merged

Conversation

baracudda
Copy link
Contributor

For the Reviewer

  • Code review complete
  • Testing Complete
  • Quality ORT App Documentation Updated (your name is in the Validator square for this feature)

When this is complete, you should approve the PR via github.

For the Reviewee

Summary

Contact list selection Send Message did not have a confirmation dialog.

Release Note

Contact list selection Send Message did not have a confirmation dialog.

Breaking Changes

None.

Quality Assurance

You have gathered the following items:

  • This PR is tagged with a Release Milestone
  • You have a log message clearly identifying when this feature is working successfully
  • You have a log message clearly identifying when this feature is failing
  • You added a PR against p4-alerting to trigger based on the failure condition above

Given all of the items above, you have updated your Application ORT at the following locations:

  • Features and Alerting: Required.
  • P4 Alerting: Required.

Testing and Verification

Send Messages buttons in:
Messages page
Contact page
Contact List page, when message checked

in all areas, send a message and Cancel/Send to ensure a confirmation dialog shows up and both options work as expected.

@baracudda baracudda added this to the 4.0.17 milestone Dec 1, 2022
@baracudda baracudda merged commit 09ee7b3 into develop Dec 2, 2022
@baracudda baracudda deleted the dev/P4-4131 branch December 2, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants