Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P4-4128 & P4-4130 & P4-4129: error NoneType is not iterable #281

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

baracudda
Copy link
Contributor

@baracudda baracudda commented Dec 3, 2022

For the Reviewer

  • Code review complete
  • Testing Complete
  • Quality ORT App Documentation Updated (your name is in the Validator square for this feature)

When this is complete, you should approve the PR via github.

For the Reviewee

Summary

When checking for TEL in channel schemes to auto-allow International Calls, ensure it is not None first.

Breaking Changes

Fixed error when adding Nexmo(Vonage) and Twilio channels.

Quality Assurance

You have gathered the following items:

  • This PR is tagged with a Release Milestone
  • You have a log message clearly identifying when this feature is working successfully
  • You have a log message clearly identifying when this feature is failing
  • You added a PR against p4-alerting to trigger based on the failure condition above

Given all of the items above, you have updated your Application ORT at the following locations:

  • Features and Alerting: Required.
  • P4 Alerting: Required.

Testing and Verification

Test steps should now succeed for:

Nexmo(Vonage) channel

Twilio Channel

Telegram Channel

@baracudda baracudda added this to the 4.0.17 milestone Dec 3, 2022
@baracudda baracudda changed the title P4-4128 & P4-4130: error NoneType is not iterable P4-4128 & P4-4130 & P4-4129: error NoneType is not iterable Dec 3, 2022
@baracudda baracudda merged commit 7b4da57 into develop Dec 16, 2022
@baracudda baracudda deleted the dev/P4-4128 branch December 16, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants