Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-23: add alt callback domain #285

Merged
merged 2 commits into from
Dec 21, 2022
Merged

PE-23: add alt callback domain #285

merged 2 commits into from
Dec 21, 2022

Conversation

baracudda
Copy link
Contributor

For the Reviewer

  • Code review complete
  • Testing Complete
  • Quality ORT App Documentation Updated (your name is in the Validator square for this feature)

When this is complete, you should approve the PR via github.

For the Reviewee

Summary

Add an ENV var for an alternate channel callback domain which applies to all orgs.

Release Note

Add an ENV var for an alternate channel callback domain which applies to all orgs.

Breaking Changes

None.

Quality Assurance

You have gathered the following items:

  • This PR is tagged with a Release Milestone
  • You have a log message clearly identifying when this feature is working successfully
  • You have a log message clearly identifying when this feature is failing
  • You added a PR against p4-alerting to trigger based on the failure condition above

Given all of the items above, you have updated your Application ORT at the following locations:

  • Features and Alerting: Required.
  • P4 Alerting: Required.

Testing and Verification

speficially if your channel callback domain is different from the website's normal domain

@baracudda baracudda added this to the 4.0.17 milestone Dec 20, 2022
Copy link
Contributor

@andrewkcarter andrewkcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the where get_brand_domain() is getting called and the value set to Channel.CONFIG_CALLBACK_DOMAIN, but I assume thats a function call made by some other code you didn't need to touch.

@baracudda baracudda merged commit 11fcbb0 into develop Dec 21, 2022
@baracudda baracudda deleted the dev/PE-23 branch December 21, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants