Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-41 Postoffice: Add support for Session - Private Messenger #288

Merged
merged 6 commits into from
Feb 28, 2023

Conversation

jpage4500
Copy link
Contributor

For the Reviewer

  • Code review complete
  • Testing Complete
  • Quality ORT App Documentation Updated (your name is in the Validator square for this feature)

When this is complete, you should approve the PR via github.

For the Reviewee

Summary

Description of changes.

Release Note

Required.

Breaking Changes

<Description for Techops of how to handle changes, migrations, updates>None.

Quality Assurance

You have gathered the following items:

  • This PR is tagged with a Release Milestone
  • You have a log message clearly identifying when this feature is working successfully
  • You have a log message clearly identifying when this feature is failing
  • You added a PR against p4-alerting to trigger based on the failure condition above

Given all of the items above, you have updated your Application ORT at the following locations:

  • Features and Alerting: Required.
  • P4 Alerting: Required.

Testing and Verification

Steps to test your application for someone not familiar with it. Required.

  1. Do this: $ run-this.sh
  2. Look for this.
  3. Clean up with this command

@jpage4500 jpage4500 added the WIP label Feb 14, 2023
@jpage4500 jpage4500 removed the WIP label Feb 28, 2023
Copy link
Contributor

@baracudda baracudda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpage4500 jpage4500 merged commit 821c627 into develop Feb 28, 2023
@jpage4500 jpage4500 deleted the feature/PE-41-session-messenger branch February 28, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants