Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-164 - Patcher to fix ticketing page #315

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

jeremyist
Copy link
Contributor

For the Reviewer

  • Code review complete
  • Testing Complete
  • Quality ORT App Documentation Updated (your name is in the Validator square for this feature)

When this is complete, you should approve the PR via github.

For the Reviewee

Summary

Added a patch to override as_json so API responses only contain a subset of the extra data we are adding in to mailroom events.

Release Note

Fixed a bug that prevented the rapidpro ticket page from loading

Breaking Changes

None.

Quality Assurance

You have gathered the following items:

  • This PR is tagged with a Release Milestone
  • You have a log message clearly identifying when this feature is working successfully
  • You have a log message clearly identifying when this feature is failing
  • You added a PR against p4-alerting to trigger based on the failure condition above

Given all of the items above, you have updated your Application ORT at the following locations:

  • Features and Alerting: Required.
  • P4 Alerting: Required.

Testing and Verification

  1. Create a flow with a Open Ticket event.
  2. Send the flow to a contact
  3. Navigate to contacts -> open tickets -> and click on the ticket. It should load.

@baracudda baracudda merged commit f4f015b into develop Oct 16, 2023
@baracudda baracudda deleted the dev/PE-164-serializefix branch October 16, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants