-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency phpunit/phpunit to v9.6.22 #614
base: next
Are you sure you want to change the base?
Conversation
f241fe9
to
4070848
Compare
4070848
to
67e5e74
Compare
67e5e74
to
59f8666
Compare
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughThe pull request updates dependency version constraints in three different Changes
Possibly related PRs
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
59f8666
to
4c23a98
Compare
4c23a98
to
f15043f
Compare
f15043f
to
463abc5
Compare
463abc5
to
58575b3
Compare
58575b3
to
5d4500f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
zmsstatistic/composer.json (1)
34-34
: 💡 Verification agent❓ Verification inconclusive
Ensure Consistent PHPUnit Version
The require-dev section specifies
"phpunit/phpunit": "^9.5.4"
, which is inconsistent with the intended update to v9.6.22. For consistency across components, consider updating this constraint (e.g., to"^9.6.22"
or a similar explicit constraint) so that the same PHPUnit version is used project‑wide.
Update PHPUnit Version Constraint in Composer.json
The
require-dev
section inzmsstatistic/composer.json
currently specifies"phpunit/phpunit": "^9.5.4"
, which does not align with the intended update to v9.6.22. For project-wide consistency, please update this constraint to reflect the new version (e.g., change it to"^9.6.22"
).
- File:
zmsstatistic/composer.json
- Suggested change (line 34):
- "phpunit/phpunit": "^9.5.4", + "phpunit/phpunit": "^9.6.22",
🧹 Nitpick comments (3)
zmsentities/composer.json (1)
48-48
: Revisit Unrestrictedsquizlabs/php_codesniffer
ConstraintChanging the version constraint from a caret range (previously
"^3.5.8"
) to"*"
removes any version restrictions. This may inadvertently pull in versions with breaking changes. Consider narrowing the constraint to a more stable range to prevent unexpected issues in your development environment.zmsmessaging/composer.json (2)
45-45
: Verifyphpmd/phpmd
Stable ConstraintThe dependency
"phpmd/phpmd"
has been changed to"@stable"
. This should generally point to the latest stable release; however, please verify that the current stable release is compatible with your codebase and does not introduce any regressions compared to the previous"^2.3"
constraint.
46-46
: Revisit Unrestrictedsquizlabs/php_codesniffer
ConstraintSimilar to the change in
zmsentities/composer.json
, the version constraint for"squizlabs/php_codesniffer"
is now"*"
. Removing version restrictions might lead to unintended updates that could break tests or code style checks. Consider restricting this to a known stable version range.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (12)
mellon/composer.lock
is excluded by!**/*.lock
zmsadmin/composer.lock
is excluded by!**/*.lock
zmsapi/composer.lock
is excluded by!**/*.lock
zmscalldisplay/composer.lock
is excluded by!**/*.lock
zmscitizenapi/composer.lock
is excluded by!**/*.lock
zmsclient/composer.lock
is excluded by!**/*.lock
zmsdb/composer.lock
is excluded by!**/*.lock
zmsdldb/composer.lock
is excluded by!**/*.lock
zmsentities/composer.lock
is excluded by!**/*.lock
zmsmessaging/composer.lock
is excluded by!**/*.lock
zmsslim/composer.lock
is excluded by!**/*.lock
zmsticketprinter/composer.lock
is excluded by!**/*.lock
📒 Files selected for processing (3)
zmsentities/composer.json
(1 hunks)zmsmessaging/composer.json
(1 hunks)zmsstatistic/composer.json
(1 hunks)
🔇 Additional comments (2)
zmsentities/composer.json (1)
45-45
: Ensure Consistent PHPUnit VersionThe
"phpunit/phpunit"
dependency is declared as"^9.6"
. While this typically allows patch updates (which would include v9.6.22), verify that your dependency resolution indeed picks the updated version. For complete control and clarity across components, you might consider making the version constraint more explicit if needed.zmsstatistic/composer.json (1)
47-47
: Downgrade offirebase/php-jwt
DependencyThe dependency for
"firebase/php-jwt"
has been downgraded fromv6.11.0
tov6.10.2
. Please confirm that this downgrade is intentional and that none of your code or dependent packages require features or fixes introduced in v6.11.0.
zmsmessaging/composer.json
Outdated
@@ -42,8 +42,8 @@ | |||
"require-dev": { | |||
"phpunit/phpunit": "^9.5.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
❓ Verification inconclusive
Align PHPUnit Dependency Version
The require-dev section sets "phpunit/phpunit": "^9.5.4"
, which is lower than the target v9.6.22. To maintain consistency with other components and meet the PR objective, update this constraint to match the updated version.
Update PHPUnit Version in zmsmessaging/composer.json
Please update the dependency in the require-dev section on line 43 from:
- "phpunit/phpunit": "^9.5.4",
+ "phpunit/phpunit": "^9.6.22",
This change aligns the PHPUnit version with the target v9.6.22 and ensures consistency with other components.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
"phpunit/phpunit": "^9.5.4", | |
"phpunit/phpunit": "^9.6.22", |
4a93d31
to
034e2a2
Compare
034e2a2
to
9e9f6f9
Compare
9e9f6f9
to
a0a33b2
Compare
This PR contains the following updates:
9.6.21
->9.6.22
9.6.7
->9.6.22
9.6.13
->9.6.22
9.6.10
->9.6.22
9.6.19
->9.6.22
Release Notes
sebastianbergmann/phpunit (phpunit/phpunit)
v9.6.22
: PHPUnit 9.6.22Compare Source
Fixed
How to install or update PHPUnit
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.