ISI-837 Auslösen von Sobon Berechnung und Auswahl des Sobon wichtigem Fördermix #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Umlegung Review Änderungen implementiert * Precision angepasst * Kommentar entfernt * Testing added * Kommentar entfernt * Logik bezüglich Gültig ab gefixt * Repository Method fixed
…github.com/it-at-m/isi-backend into ISI-926-planungsursaechliche-wohneinheiten
…-926-planungsursaechliche-wohneinheiten
…-926-planungsursaechliche-wohneinheiten
TiagoKocevar
force-pushed
the
ISI-837-SoBoN-Ursaechlicher-Fördermix-Auslösen
branch
from
640c606 to
3d7078e
Compare
TiagoKocevar
changed the title
boal
requested changes
Mar 12, 2024
src/main/java/de/muenchen/isi/api/validation/SobonFoerdermixBauleitplanverfahrenAVValid.java
Outdated
Show resolved
Hide resolved
...itung/AbfragevarianteBauleitplanverfahrenSachbearbeitungInBearbeitungSachbearbeitungDto.java
Outdated
Show resolved
Hide resolved
src/main/java/de/muenchen/isi/domain/service/calculation/CalculationService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/muenchen/isi/domain/service/calculation/CalculationService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/muenchen/isi/infrastructure/entity/AbfragevarianteWeiteresVerfahren.java
Outdated
Show resolved
Hide resolved
…-837-SoBoN-Ursaechlicher-Fördermix-Auslösen
boal
requested changes
Mar 13, 2024
src/main/java/de/muenchen/isi/api/validation/FoerdermixNotEmptyValidator.java
Show resolved
Hide resolved
src/main/java/de/muenchen/isi/domain/service/calculation/CalculationService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/muenchen/isi/domain/service/calculation/CalculationService.java
Outdated
Show resolved
Hide resolved
src/main/java/de/muenchen/isi/infrastructure/entity/AbfragevarianteWeiteresVerfahren.java
Show resolved
Hide resolved
src/main/java/de/muenchen/isi/infrastructure/entity/common/SobonBerechnung.java
Outdated
Show resolved
Hide resolved
src/main/java/de/muenchen/isi/infrastructure/entity/AbfragevarianteBauleitplanverfahren.java
Show resolved
Hide resolved
boal
previously approved these changes
Mar 13, 2024
boal
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Neue Attribute isASobonBerechnung (boolean) und sobonFoerdermix (Foerdermix).
Wenn isASobonBerechnung wahr ist soll eine SobonBerechnung ausgeführt werden. Aber nur wenn auch der sobonFoerdermix gesetzt wurde.
Dann wird der sobonFoerdermix als Basis hergenommen für die Berechnung.
Validation hinzugefügt das sobonFoerdermix einen Wert haben muss wenn isASobonBerechnung wahr ist.
Außerdem Validation abgeändert bei der Fördermixklasse da bei der Abfragevariante die Felder sobonFoerdermix und isASobonBerechnung null sein dürfen.
Reference
Issues #837