Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task architecture app #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Ludmilka1201
Copy link
Contributor

No description provided.

@Ludmilka1201 Ludmilka1201 linked an issue Sep 25, 2024 that may be closed by this pull request
Copy link

@Medvedev421 Medvedev421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Проверил

Copy link
Contributor

@anst-foto anst-foto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переделать

class_diagram.md Outdated
Comment on lines 2 to 3
`AccountingForOrders`
## Учет клиентов
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`AccountingForOrders`
## Учет клиентов
## Учет клиентов
`AccountingForOrders`

class_diagram.md Outdated
Comment on lines 20 to 35
class AOrder {
<<Abstract>>

+ sring number
+ string data
+ string comments
}
AOrder <|-- OrderItem
OrderItem *-- ProductQuantity
OrderItem *-- ClientYL
class OrderItem {
+ string plann_date_of_execution
+ string fact_date of execution
+ vector<ProductQuantity> products

}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Точно тут должно находиться?

class_diagram.md Outdated
Comment on lines 20 to 26
class AOrder {
<<Abstract>>

+ sring number
+ string data
+ string comments
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Кажется этот класс нам не потребуется

class_diagram.md Outdated
+ Product* product
+ int quantity
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

+ int quantity
}

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```

class_diagram.md Outdated

AStage <|-- StageItem
class StageItem {
+ string equipment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

указатель на станок

class_diagram.md Outdated
classDiagram
class EquipmentAccounting {
+ int accession_number
+ string specialist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

указатель на специалиста/сотрудника

class_diagram.md Outdated
+ string specialist
+ string name
+ string status
+ string workshop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для цеха нужно подумать о создании своего класса

class_diagram.md Outdated
+ int accession_number
+ string specialist
+ string name
+ string status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно подумать о своём классе

class_diagram.md Outdated
```mermaid
classDiagram
class EmployeeAccounting{
+ string full_name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше разбить ФИО на три отдельных поля

Copy link

@Medvedev421 Medvedev421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Передал ревью более опытному

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task_architecture_app
4 participants