Ratings showing fixed #1516
Ratings showing fixed #1516
Conversation
ZdorovenkoKyrylo
force-pushed
the
Zdorovenko/Ratings
branch
from
96577a3 to
5b29ec6
Compare
OutOfSchool/OutOfSchool.WebApi/Extensions/ElasticsearchExtension.cs
Outdated
Show resolved
Hide resolved
| @@ -43,6 +43,7 @@ public async Task<AverageRatingDto> GetByEntityIdAsync(Guid entityId) | |||
| logger.LogInformation("Getting the average rating by workshop's or provider's id started."); | |||
|
|
|||
| var rating = (await averageRatingRepository.GetByFilter(r => r.EntityId == entityId).ConfigureAwait(false)).SingleOrDefault(); | |||
| rating.Rate = (float)Math.Round(rating.Rate); | |||
There was a problem hiding this comment.
Sorry, but when I see "showing" bug, I expect it to be fixed somewhere in presentation layer (not business logic) using something as simple as formatting. Could it be done there?
There was a problem hiding this comment.
Thank you for the comment. As far as I understand this rounding must be working either in elastic or in database. So, I found that like the only way to implement that requirement. Maybe it will be reasonable to move somewhere this logic but I assume it won`t, because the presentation in both elastic and database seems pretty similar to changing logic to me.
There was a problem hiding this comment.
@VadymLevkovskyi I also had some changes in mapping lines, you probably saw it when reviewed. That is how I tried to fix the problem with ratings. There were no visible ratings in elastic. Then the version of the elastic was changed and I do not know what was the reason but now ratings work even without those changes in mapping. that is why PR is still draft. And maybe you have some thoughts on this issue. I do not deny I might forget something while checking that is why I am still thinking about that.
There was a problem hiding this comment.
Sorry, can't give any suggestion why it works/or doesn`t.
Now I'm resolving this comment, and asking you to either undraft (proceed with fixing the code) or close the PR
|
| @@ -1,3 +1,4 @@ | |||
| using AutoMapper; | |||
There was a problem hiding this comment.
Is this using needed?
No description provided.