Dvorak / 2698 Clear filters button improvement

[AkunaPatlata]

#2698

Summary by CodeRabbit

• UI/UX Improvements
  • Updated reset filters button with a new icon and styling.
  • Refined padding and layout for filter-related elements.
  • Introduced a new styling option for filter elements.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the filter reset button in the filters-list component. The changes involve replacing the Material icon with an image element and adjusting the layout and styling of the reset filter button. The updates are reflected in the HTML template and associated SCSS styles, enhancing the visual representation while preserving the existing functionality of resetting filters.

Changes

File	Change Summary
src/app/shared/components/filters-list/filters-list.component.html	Replaced Material icon with an <i> SVG element for the clear-all icon, wrapped in a <div class="flex"> with translated text in a <span>
src/app/shared/components/filters-list/filters-list.component.scss	Updated .reset-filter class padding to 0 2px 0 2px, added new .mat-filter class with background image and padding-right: 20px

Poem

🐰 Filters dancing, a new design takes flight,
SVG icon gleaming, oh so bright!
Padding tweaked with rabbit's care,
A reset button beyond compare
Hop, hop, hooray for clean and neat! 🧹

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c70ec7 and a2acabb.

📒 Files selected for processing (1)

• src/app/shared/components/filters-list/filters-list.component.html (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/app/shared/components/filters-list/filters-list.component.html

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: SonarCloud
• GitHub Check: build_and_test

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (3)

src/app/shared/components/filters-list/filters-list.component.scss (1)

69-71: Consider following Angular Material naming conventions.

The class name should follow Angular Material naming conventions by using the mat- prefix.

-.matFilter {
+.mat-filter-icon {
   padding-right: 4px;
 }

src/app/shared/components/filters-list/filters-list.component.html (2)

5-5: Use asset paths from environment configuration.

The relative path to the SVG icon could break if the component structure changes. Consider defining asset paths in the environment configuration.

-<img alt="clear-all-icon" class="matFilter" src="../../../../assets/icons/clear-all.svg" />
+<img alt="clear-all-icon" class="matFilter" [src]="environment.assetsPath + '/icons/clear-all.svg'" />

Don't forget to:

1. Add environment import
2. Define assetsPath in your environment files

---

4-7: Add width and height attributes to the SVG image.

To prevent layout shifts and improve Core Web Vitals, specify explicit dimensions for the SVG image.

 <div class="flex">
-  <img alt="clear-all-icon" class="matFilter" src="../../../../assets/icons/clear-all.svg" />
+  <img alt="clear-all-icon" class="matFilter" src="../../../../assets/icons/clear-all.svg" width="16" height="16" />
   <span>{{ 'CLEAR_FILTERS' | translate }}</span>
 </div>

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8d8c0e and 28a4c36.

⛔ Files ignored due to path filters (1)

• src/assets/icons/clear-all.svg is excluded by !**/*.svg, !src/assets/** and included by src/**

📒 Files selected for processing (2)

• src/app/shared/components/filters-list/filters-list.component.html (1 hunks)
• src/app/shared/components/filters-list/filters-list.component.scss (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: SonarCloud
• GitHub Check: build_and_test

🔇 Additional comments (1)

src/app/shared/components/filters-list/filters-list.component.scss (1)

48-48: LGTM! Improved button content spacing.

The added horizontal padding provides better visual spacing around the button content while maintaining the vertical alignment.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud