Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed needAction according to backend changes #2988

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Fixed needAction according to backend changes #2988

merged 6 commits into from
Jan 28, 2025

Conversation

Made1ra
Copy link
Contributor

@Made1ra Made1ra commented Dec 16, 2024 •
edited
Loading

Use backend 1016 branch to test it.
Changed all needAction logic according to new structure:
ita-social-projects/SpaceToStudy-BackEnd#1016

status: "Request to close",
needAction: {
    role: "tutor"
    type: "waiting for approval"
    messages: []
}

It should be merged only after backend PR.

@Made1ra Made1ra added enhancement New feature or request Frontend part labels Dec 16, 2024
@Made1ra Made1ra self-assigned this Dec 16, 2024
@Made1ra Made1ra linked an issue Dec 16, 2024 that may be closed by this pull request
Fix needAction according to backend changes #2957
Closed
@Made1ra Made1ra marked this pull request as ready for review December 17, 2024 09:59
@Made1ra Made1ra force-pushed the bugfix/2957/fix-need-action-according-to-backend-changes branch from 3b6cabe to 4046848 Compare December 30, 2024 19:47
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dudchakk dudchakk merged commit 46d41aa into develop Jan 28, 2025
10 checks passed
@dudchakk dudchakk deleted the bugfix/2957/fix-need-action-according-to-backend-changes branch January 28, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SofiiaYevush SofiiaYevush SofiiaYevush approved these changes

@markgol777 markgol777 markgol777 approved these changes

@VKormylo VKormylo VKormylo approved these changes

@dudchakk dudchakk Awaiting requested review from dudchakk

@ShadowOfTheSpace ShadowOfTheSpace Awaiting requested review from ShadowOfTheSpace

@luiqor luiqor Awaiting requested review from luiqor

@amoutens amoutens Awaiting requested review from amoutens

@RomanRozbytskyi RomanRozbytskyi Awaiting requested review from RomanRozbytskyi

Assignees

@Made1ra Made1ra

Labels
enhancement New feature or request Frontend part on Hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix needAction according to backend changes
5 participants
@Made1ra @VKormylo @markgol777 @SofiiaYevush @dudchakk