Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced useAxios with useQuery and useMutation hooks on CategoryDropdown container #3102

Merged

Conversation

amoutens
Copy link
Contributor

@amoutens amoutens commented Jan 15, 2025

  1. CategoryDropdown component was updated with useQuery on GET response and useQuery and useMutation hooks on POST response.
  2. resource-service was updated with using baseService
  3. Changed all occurrences in AppButtonMenu, CategoriesContainer etc.

Example of usage after replacing useAxios with useQuery:
https://github.com/user-attachments/assets/cd627f1f-06a7-41f3-a439-9fe3b6ce27a7

@amoutens amoutens linked an issue Jan 15, 2025 that may be closed by this pull request
@amoutens amoutens self-assigned this Jan 15, 2025
@amoutens amoutens marked this pull request as draft January 15, 2025 13:47
src/components/app-button-menu/AppButtonMenu.tsx Outdated Show resolved Hide resolved
src/components/app-button-menu/AppButtonMenu.tsx Outdated Show resolved Hide resolved
src/containers/category-dropdown/CategoryDropdown.tsx Outdated Show resolved Hide resolved
src/containers/category-dropdown/CategoryDropdown.tsx Outdated Show resolved Hide resolved
src/containers/category-dropdown/CategoryDropdown.tsx Outdated Show resolved Hide resolved
src/services/resource-service.ts Outdated Show resolved Hide resolved
src/services/resource-service.ts Outdated Show resolved Hide resolved
@ShadowOfTheSpace
Copy link
Contributor

Please, try to remove commits from other branches with rebase

src/services/resource-service.ts Outdated Show resolved Hide resolved
src/components/app-button-menu/AppButtonMenu.tsx Outdated Show resolved Hide resolved
src/containers/category-dropdown/CategoryDropdown.tsx Outdated Show resolved Hide resolved
src/containers/category-dropdown/CategoryDropdown.tsx Outdated Show resolved Hide resolved
src/containers/category-dropdown/CategoryDropdown.tsx Outdated Show resolved Hide resolved
@amoutens amoutens merged commit a06168c into develop Jan 29, 2025
10 checks passed
@amoutens amoutens deleted the feature/3074/replace-useAxios-with-useQuery-categoryDropdown branch January 29, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Replace useAxios with useQuery on the CategoryDropdown page
4 participants