Replaced use axios with use query on GeneralIntoStep container #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavloButynets
requested review from
ShadowOfTheSpace,
markgol777,
Made1ra,
amoutens,
luiqor,
SofiiaYevush and
nebby2105
5 tasks
5 tasks
5 tasks
|
ShadowOfTheSpace
requested changes
Feb 4, 2025
| if (userResponse) { | ||
| updateUserName(userResponse) | ||
| } | ||
| }, [userResponse]) |
There was a problem hiding this comment.
We need to discuss problems with useForm hook on our next daily call, remind me please about it
| @@ -1,8 +1,10 @@ | |||
| import { AxiosResponse } from 'axios' | |||
| import { URLs } from '~/constants/request' | |||
| import { axiosClient } from '~/plugins/axiosClient' | |||
| import { Course, CourseForm, GetCoursesParams } from '~/types' | |||
| import { Course, CourseForm, GetCoursesParams, ItemsWithCount } from '~/types' | |||
There was a problem hiding this comment.
Suggested change
| import { Course, CourseForm, GetCoursesParams, ItemsWithCount } from '~/types' | |
| import type { Course, CourseForm, GetCoursesParams, ItemsWithCount } from '~/types' |
| parameters: { id }, | ||
| searchParameters: { | ||
| role: userRole, | ||
| isEdit: isEdit !== undefined ? isEdit.toString() : undefined |
There was a problem hiding this comment.
I saw the same in one of your previous PRs, did I missed something?
Suggested change
| isEdit: isEdit !== undefined ? isEdit.toString() : undefined | |
| isEdit: isEdit?.toString() ?? undefined |
There was a problem hiding this comment.
yes, I forgot to fix it in this PR too, but I'll first merge the previous PR and then do a rebase
There was a problem hiding this comment.
You need to rebase your other branch and then do rebase on this branch. Don't use merge, please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced useAxios with useQuery on the GeneralIntoStep container, fixed tests and removed unnecessary isUserFetched and setIsUserFetched